Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEN-644 - feat(OfferPresenter): display discount #2669

Merged
merged 4 commits into from
Jul 6, 2023
Merged

GEN-644 - feat(OfferPresenter): display discount #2669

merged 4 commits into from
Jul 6, 2023

Conversation

guilhermespopolin
Copy link
Contributor

@guilhermespopolin guilhermespopolin commented Jul 3, 2023 •
edited
Loading

Describe your changes

  • Update Offer Presenter so discounts get shown
  • General refactoring: move useDiscountExplanation into global utility

image

Justify why they are needed

  • Requested by design.

@vercel
Copy link

vercel bot commented Jul 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hedvig-dot-com ✅ Ready (Inspect) Visit Preview Jul 6, 2023 7:51am
onboarding ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2023 7:51am

@guilhermespopolin
Copy link
Contributor Author

guilhermespopolin commented Jul 3, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@guilhermespopolin guilhermespopolin changed the title feat(OfferPresenter): display discount GEN-644 - feat(OfferPresenter): display discount Jul 3, 2023
@notion-workspace
Copy link

Display discount in Offer Presenter

@guilhermespopolin guilhermespopolin marked this pull request as ready for review July 3, 2023 12:44
@guilhermespopolin guilhermespopolin requested a review from a team as a code owner July 3, 2023 12:44
@guilhermespopolin guilhermespopolin force-pushed the GEN-644/feat/offer-presenter-discount branch from 57342cf to 58a15be Compare July 3, 2023 12:46
alebedev
alebedev approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@alebedev alebedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

apps/store/src/components/ProductPage/PurchaseForm/OfferPresenter.tsx Outdated Show resolved Hide resolved
@guilhermespopolin guilhermespopolin force-pushed the GEN-644/feat/offer-presenter-discount branch from 58a15be to 8f6ee6d Compare July 4, 2023 08:26
@guilhermespopolin guilhermespopolin force-pushed the GEN-644/feat/offer-presenter-discount branch from 8f6ee6d to 663ad16 Compare July 4, 2023 16:23
@guilhermespopolin guilhermespopolin force-pushed the GEN-644/feat/offer-presenter-discount branch from 663ad16 to 44b1128 Compare July 5, 2023 07:50
@guilhermespopolin guilhermespopolin marked this pull request as draft July 5, 2023 09:07
@guilhermespopolin guilhermespopolin mentioned this pull request Jul 5, 2023
Merged
@guilhermespopolin guilhermespopolin marked this pull request as ready for review July 5, 2023 09:08
@guilhermespopolin guilhermespopolin force-pushed the GEN-644/feat/offer-presenter-discount branch from 8c23b24 to c58ca48 Compare July 5, 2023 09:08
robinandeer
robinandeer approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@robinandeer robinandeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@guilhermespopolin guilhermespopolin force-pushed the GEN-644/feat/offer-presenter-discount branch from c58ca48 to b109c63 Compare July 5, 2023 14:01
@guilhermespopolin guilhermespopolin mentioned this pull request Jul 5, 2023
Closed
@guilhermespopolin guilhermespopolin force-pushed the GEN-644/feat/offer-presenter-discount branch from 2ce3dab to 7554ad2 Compare July 6, 2023 07:47
@guilhermespopolin
Copy link
Contributor Author

@guilhermespopolin started a stack merge that includes this pull request via Graphite.

@guilhermespopolin guilhermespopolin merged commit 2cadb2a into main Jul 6, 2023
3 checks passed
@guilhermespopolin guilhermespopolin deleted the GEN-644/feat/offer-presenter-discount branch July 6, 2023 07:58
@guilhermespopolin
Copy link
Contributor Author

@guilhermespopolin merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alebedev alebedev alebedev approved these changes

@robinandeer robinandeer robinandeer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guilhermespopolin @alebedev @robinandeer