Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEN-681 | Update global banner styles #2714

Merged
merged 1 commit into from
Jul 7, 2023
Merged

GEN-681 | Update global banner styles #2714

merged 1 commit into from
Jul 7, 2023

Conversation

robinandeer
Copy link
Contributor

@robinandeer robinandeer commented Jul 7, 2023

Describe your changes

Screenshot 2023-07-07 at 13.00.22.png

  • Increase minimum height of notification banner

  • Add bottom border to notification banner

Justify why they are needed

  • Design updates

Checklist before requesting a review

  • I have performed a self-review of my code

@robinandeer robinandeer requested a review from a team as a code owner July 7, 2023 11:02
@vercel
Copy link

vercel bot commented Jul 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hedvig-dot-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 11:10am
onboarding ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 11:10am

@robinandeer
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@robinandeer robinandeer changed the title Update global banner styles GEN-681 | Update global banner styles Jul 7, 2023
@notion-workspace
Copy link

Copy link
Member

@gustaveen gustaveen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@robinandeer robinandeer merged commit 42bb9bd into main Jul 7, 2023
@robinandeer robinandeer deleted the update/banner branch July 7, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants