Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deserializing stepper input #2800

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Conversation

alebedev
Copy link
Contributor

Describe your changes

Fix stepper field behavior when non-empty initial value was provided. It took 2 as string ("2") and then button behaved like "2" + 1 = "21"

Justify why they are needed

Fix co-insured field behavior when editing previously entered value

Checklist before requesting a review

  • I have performed a self-review of my code

@vercel
Copy link

vercel bot commented Jul 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hedvig-dot-com 🛑 Canceled (Inspect) Jul 18, 2023 8:13am
onboarding ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2023 8:13am

@alebedev
Copy link
Contributor Author

Copy link
Contributor

@robinandeer robinandeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh nice catch! Damn JS

@alebedev alebedev force-pushed the fix/less-noisy-trustpilot-errors branch from f120502 to 32393f0 Compare July 18, 2023 07:56
@alebedev alebedev force-pushed the fix/stepper-input-deserialize branch from 498d91a to 770c284 Compare July 18, 2023 07:56
Base automatically changed from fix/less-noisy-trustpilot-errors to main July 18, 2023 08:05
@alebedev
Copy link
Contributor Author

Graphite rebased this pull request as part of a merge.

@alebedev alebedev force-pushed the fix/stepper-input-deserialize branch from 770c284 to 9df9b95 Compare July 18, 2023 08:06
@alebedev alebedev merged commit 5e06756 into main Jul 18, 2023
@alebedev
Copy link
Contributor Author

@alebedev merged this pull request with Graphite.

@alebedev alebedev deleted the fix/stepper-input-deserialize branch July 18, 2023 08:09
@vercel vercel bot temporarily deployed to Preview – hedvig-dot-com July 18, 2023 08:13 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants