-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deserializing stepper input #2800
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Jul 17, 2023
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
robinandeer
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhh nice catch! Damn JS
guilhermespopolin
approved these changes
Jul 18, 2023
alebedev
force-pushed
the
fix/less-noisy-trustpilot-errors
branch
from
July 18, 2023 07:56
f120502
to
32393f0
Compare
alebedev
force-pushed
the
fix/stepper-input-deserialize
branch
from
July 18, 2023 07:56
498d91a
to
770c284
Compare
Graphite rebased this pull request as part of a merge. |
alebedev
force-pushed
the
fix/stepper-input-deserialize
branch
from
July 18, 2023 08:06
770c284
to
9df9b95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fix stepper field behavior when non-empty initial value was provided. It took 2 as string ("2") and then button behaved like "2" + 1 = "21"
Justify why they are needed
Fix co-insured field behavior when editing previously entered value
Checklist before requesting a review