Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower serverity of missing Trustpilot settings #2792

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Lower serverity of missing Trustpilot settings #2792

merged 1 commit into from
Jul 18, 2023

Conversation

alebedev
Copy link
Contributor

Describe your changes

Reduce noise from Trustpilot not being configured. Warn in production, info otherwise

Justify why they are needed

Improve developer experience

Checklist before requesting a review

  • I have performed a self-review of my code

@vercel
Copy link

vercel bot commented Jul 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hedvig-dot-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2023 8:11am
onboarding ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2023 8:11am

@alebedev alebedev mentioned this pull request Jul 17, 2023
Merged
1 task
@alebedev
Copy link
Contributor Author

alebedev commented Jul 17, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

Base automatically changed from feat/redirect-old-campaign to main July 17, 2023 09:59
@alebedev alebedev force-pushed the fix/less-noisy-trustpilot-errors branch from c64fe2e to f120502 Compare July 17, 2023 13:32
@alebedev alebedev mentioned this pull request Jul 17, 2023
Merged
1 task
robinandeer
robinandeer suggested changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@robinandeer robinandeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change!

But I think there's an import that shouldn't be there 🤔

apps/store/src/services/trustpilot/trustpilot.tsx Outdated Show resolved Hide resolved
guilhermespopolin
guilhermespopolin approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@guilhermespopolin guilhermespopolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite the "process import thing" Robin mentioned, it looks good :)

@alebedev alebedev force-pushed the fix/less-noisy-trustpilot-errors branch from f120502 to 32393f0 Compare July 18, 2023 07:56
@alebedev alebedev merged commit 558408b into main Jul 18, 2023
@alebedev alebedev deleted the fix/less-noisy-trustpilot-errors branch July 18, 2023 08:05
@alebedev
Copy link
Contributor Author

@alebedev merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilhermespopolin guilhermespopolin guilhermespopolin approved these changes

@robinandeer robinandeer robinandeer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alebedev @robinandeer @guilhermespopolin