Refactor styling of debug dialog #2802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Jul 17, 2023
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
1 task
alebedev
reviewed
Jul 18, 2023
robinandeer
force-pushed
the
07-17-Refactor_styling_of_debug_dialog
branch
from
d675c78
to
7cb46bc
Compare
robinandeer
force-pushed
the
07-17-Add_resume_shop_session_form_to_debug_dialog
branch
from
7217a76
to
5a28eb5
Compare
robinandeer
force-pushed
the
07-17-Refactor_styling_of_debug_dialog
branch
from
7cb46bc
to
498e9de
Compare
alebedev
approved these changes
Jul 18, 2023
| @@ -47,7 +47,7 @@ export const DebugResumeSessionSection = () => { | |||
|
|
|||
| const Layout = styled.form({ | |||
There was a problem hiding this comment.
Nit: now we have grid with single line, right? Maybe flexbox would be more obvious
There was a problem hiding this comment.
Hmmm but then we need to add "flex" properties to children to determine how they scale horizontally
That's why I like grid -- it let's you determine layout from the parent 🙂
|
@robinandeer started a stack merge that includes this pull request via Graphite. |
robinandeer
force-pushed
the
07-17-Add_resume_shop_session_form_to_debug_dialog
branch
from
5a28eb5
to
e8ab425
Compare
Base automatically changed from
07-17-Add_resume_shop_session_form_to_debug_dialog
to
main
July 18, 2023 08:08
|
Graphite rebased this pull request as part of a merge. |
robinandeer
force-pushed
the
07-17-Refactor_styling_of_debug_dialog
branch
from
498e9de
to
22f768d
Compare
|
@robinandeer merged this pull request with Graphite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Justify why they are needed
I wanted it go along with input fields
The button height doesn't match input fields so they look a little strange
Checklist before requesting a review