Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default debug dialog for all CMS pages #2803

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

robinandeer
Copy link
Contributor

@robinandeer robinandeer commented Jul 17, 2023

Describe your changes

Screenshot 2023-07-17 at 16.55.28.png

  • See title

Justify why they are needed

  • So you can easily grab the shop session

Checklist before requesting a review

  • I have performed a self-review of my code

@vercel
Copy link

vercel bot commented Jul 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hedvig-dot-com 🛑 Canceled (Inspect) Jul 18, 2023 8:14am
onboarding 🛑 Canceled (Inspect) Jul 18, 2023 8:14am

@robinandeer
Copy link
Contributor Author

Copy link
Contributor

@alebedev alebedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can you do the same in pages/manypets/[[slug]].tsx?

Copy link
Contributor

@guilhermespopolin guilhermespopolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@robinandeer
Copy link
Contributor Author

@robinandeer started a stack merge that includes this pull request via Graphite.

@robinandeer robinandeer force-pushed the 07-17-Refactor_styling_of_debug_dialog branch from 498e9de to 22f768d Compare July 18, 2023 08:08
Base automatically changed from 07-17-Refactor_styling_of_debug_dialog to main July 18, 2023 08:09
@robinandeer robinandeer force-pushed the 07-17-Add_default_debug_dialog_for_all_CMS_pages branch from a58f474 to e00a87b Compare July 18, 2023 08:09
@robinandeer
Copy link
Contributor Author

Graphite rebased this pull request as part of a merge.

@robinandeer robinandeer merged commit 5eaa8ff into main Jul 18, 2023
@robinandeer robinandeer deleted the 07-17-Add_default_debug_dialog_for_all_CMS_pages branch July 18, 2023 08:10
@robinandeer
Copy link
Contributor Author

@robinandeer merged this pull request with Graphite.

@vercel vercel bot temporarily deployed to Preview – hedvig-dot-com July 18, 2023 08:12 Inactive
@vercel vercel bot temporarily deployed to Preview – onboarding July 18, 2023 08:14 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants