Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #137. (I can rebase as needed if there are issues with the latter).
The fixes/refactoring were part and parcel for adding full tests/coverage.
getWss
inbroadcast.js
example (also renaming variable to reflect lack of specificity to route of web socket server)upgradeReq
check (dropped back in ws 3)Re: middleware error handler,
Layer.prototype.handle_error
ofrouter
(used byexpress.Router
) only handles arity 4, so we need to return a function that has arity 4.