Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing/Coverage #138

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Testing/Coverage #138

wants to merge 3 commits into from

Commits on Jul 7, 2020

  1. - Linting: Switch to add a recommended extension (json) 

    - Linting: Lint `/examples` files also (using `overrides` to allow `console` therein)
- Refactoring: Switch to ES6 in examples and docs
- npm: Update airbnb to version advertised as compatible with exiting eslint version
    @brettz9
    brettz9 committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    b7b6494 View commit details
    Browse the repository at this point in the history

  2. - Docs: README clarifications

    @brettz9
    brettz9 committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    025b70f View commit details
    Browse the repository at this point in the history

  3. - Fix: Remove unused parameter passed to getWss in broadcast.js e… 

    …xample (also renaming variable to reflect lack of specificity to route of web socket server)

- Fix: Allow middleware error handler (arity 4) to be triggered
- Refactoring: Remove `upgradeReq` check (dropped back in ws 3)
- Testing: Add mocha/chai/nyc

Re: middleware error handler, `Layer.prototype.handle_error` of `router` (used by `express.Router`) only handles arity 4
    @brettz9
    brettz9 committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    a54f4f3 View commit details
    Browse the repository at this point in the history