-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pkg.ts #11
Update pkg.ts #11
Conversation
https://pnpm.io/cli/dlx the following doesn't work ```sh pnpm graphqurl https://spacex-production.up.railway.app --introspect ``` whereas this works ```sh pnpm dlx graphqurl https://spacex-production.up.railway.app --introspect ```
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution 🙌
I think the current behavior is correct as it's matching the pnpm exec
one which says:
The exec part is actually optional when the command is not in conflict with a builtin pnpm command […]
Altho, I think we could add a totally new command type, e.g. dlx
? What do you think?
I think that makes sense! Since
|
although just to be clear @HiDeoo, |
This is the case altho based on " |
currently with this setup: <PackageManagers
pkg="jsr"
type="exec"
frame="none"
args="add @union/client"
pkgManagers={['pnpm']}
/> it renders: pnpm jsr add @union/client which when ran results in: ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL Command "jsr" not found whereas You suggest I update the pr and add a new command for |
I think this is what we agreed on and still makes sense. I would be up to the user to use the appropriate syntax that will work based on the situation, we cannot predict what is the desired behavior in this case if I'm not missing something. |
From the discussion in HiDeoo#11 I've mirrored the implementation of the `exec` command. Note: for pnpm, whilst there is an alias — `pnpx` — I've chosen to use `pnpm dlx`, as the alias was only introduced in pnpm v9 (Apr 2024).
From the discussion in HiDeoo#11 I've mirrored the implementation of the `exec` command. Note: for pnpm, whilst there is an alias — `pnpx` — I've chosen to use `pnpm dlx`, as the alias was only introduced in pnpm v9 (Apr 2024).
Thanks to #15, the version 0.8.0 now includes the |
https://pnpm.io/cli/dlx
Describe the pull request
make pnpm exec work
Why
the following doesn't work
whereas this works
How
How were these changes implemented?
Screenshots
If applicable, add screenshots to help explain what is being modified.