Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds the dlx command type #15

Merged
merged 1 commit into from
Nov 1, 2024
Merged

feat: adds the dlx command type #15

merged 1 commit into from
Nov 1, 2024

Conversation

jits
Copy link
Contributor

@jits jits commented Oct 31, 2024

Describe the pull request

From the discussion in #11, this adds support for the dlx command.

Why

See #11

How

By mirroring the implementation of the exec command.

Screenshots

N/A


Note: for pnpm, whilst there is an alias — pnpx — I've chosen to use pnpm dlx, as the alias was only introduced in pnpm v9 (Apr 2024).

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
starlight-package-managers ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 1:30pm

From the discussion in HiDeoo#11

I've mirrored the implementation of the `exec` command.

Note: for pnpm, whilst there is an alias — `pnpx` — I've chosen to use `pnpm dlx`, as the alias was only introduced in pnpm v9 (Apr 2024).
@jits
Copy link
Contributor Author

jits commented Oct 31, 2024

@HiDeoo — please could you take a look when you have a sec? (I wasn't sure if you received notifications for this repo or not. Apologies if this results in double notifications!)

Copy link
Owner

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, only got to this notification now 🙌

This looks perfect and very thorough to me: from docs, to tests, editing the README.md file, some explanations, and the code itself. This is an amazing contribution, thank you for that!

@HiDeoo HiDeoo changed the title Support the dlx command feat: adds the dlx command type Nov 1, 2024
@HiDeoo HiDeoo merged commit b62e4c6 into HiDeoo:main Nov 1, 2024
3 checks passed
@HiDeoo HiDeoo mentioned this pull request Nov 1, 2024
@jits jits deleted the support-dlx branch November 1, 2024 12:00
@jits
Copy link
Contributor Author

jits commented Nov 1, 2024

@HiDeoo – it's my pleasure! Thank you for the plugin — it's been very handy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants