Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inference CI Triggers #466

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

TimothyWillard
Copy link
Contributor

@TimothyWillard TimothyWillard commented Jan 14, 2025

Describe your changes.

This pull request:

  1. Fixes [Bug]: Inference CI Not Running When Gempyor CI Does #411 by triggering the inference CI action on expanded set of file changes, and
  2. Adds restore keys to the R lib caching to allow caches to be pulled from prior weeks for PRs that span a while.

Does this pull request make any user interface changes? If so please describe.

The user interface changes are in PRs, users will now notice the inference CI action run when editing gempyor or flepicommon. The GitHub actions we use aren't documented anywhere that I know of, perhaps they should be added to the GitBook here: https://iddynamics.gitbook.io/flepimop/development/git-and-github-usage?

What does your pull request address? Tag relevant issues.

This pull request addresses GH-411.

@TimothyWillard TimothyWillard linked an issue Jan 14, 2025 that may be closed by this pull request
@TimothyWillard TimothyWillard added high priority High priority. quick issue Short or easy fix. meta/workflow Relating to CI / issue templates / testing frameworks / etc. labels Jan 14, 2025
@TimothyWillard TimothyWillard force-pushed the hotfix/411/fix-inference-ci-triggers branch from 23cc99d to 0c1f246 Compare January 14, 2025 16:02
@TimothyWillard TimothyWillard marked this pull request as draft January 14, 2025 16:03
Changed the `inference CI` GH action to trigger on changes to
`gempyor`/`flepicommon` files rather than the `gempyor CI`/`flepicommon
CI` workflows because of
https://github.com/orgs/community/discussions/27028.
Added `restore-keys` to the R libs caching action to `inference CI` and
`flepicommon CI`. `inference CI` can use `flepicommon CI` caches too if
there is no other hit.
@TimothyWillard TimothyWillard force-pushed the hotfix/411/fix-inference-ci-triggers branch from 0c1f246 to 6d81ea5 Compare January 14, 2025 20:17
@TimothyWillard TimothyWillard marked this pull request as ready for review January 14, 2025 20:19
@TimothyWillard TimothyWillard merged commit 8333fa4 into main Jan 15, 2025
@TimothyWillard TimothyWillard deleted the hotfix/411/fix-inference-ci-triggers branch January 15, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority High priority. meta/workflow Relating to CI / issue templates / testing frameworks / etc. quick issue Short or easy fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Inference CI Not Running When Gempyor CI Does
3 participants