-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Applying pylint
to gempyor
#500
Open
emprzy
wants to merge
6
commits into
dev
Choose a base branch
from
gempyor_pylint
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a few minor comments. One thing that is missing is documentation, probably here is most appropriate: https://iddynamics.gitbook.io/flepimop/development/python-guidelines-for-developers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Request for improvement or addition of new feature(s).
gempyor
Concerns the Python core.
medium priority
Medium priority.
meta/workflow
Relating to CI / issue templates / testing frameworks / etc.
next release
Marks a PR as a target to include in the next release.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes.
Adds a
pylint
linting GH action forgempyor
. You can also spur the linting (along withblack
formatting) before PR by running./bin/lint
from theflepiMoP
directory. Presently, the only adjustment thispylint
implementation has is a max line length of 92 chr. In the future, we may look to:--fail-under
flag for failing under a certain score,pylint
to only look at changed files?Does this pull request make any user interface changes? If so please describe.
gempyor
will now be linted withpylint
through a GH action upon PR.What does your pull request address? Tag relevant issues.
This pull request addresses GH- #398