Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where JSON error response might get treated as non-JSON error response #1407

Merged
merged 9 commits into from
Jan 8, 2025
Prev Previous commit
Next Next commit
Delete .changeset/fluffy-lamps-provide.md
Accidentally got included from the last PR I made, woops
Mtn-View authored Jan 7, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 45f60a527e66c39e1a34c2b9d24f0bd3202cbed2
5 changes: 0 additions & 5 deletions .changeset/fluffy-lamps-provide.md

This file was deleted.


Unchanged files with check annotations Beta

// load the larger image and wait for it to resolve
await page.click('#larger')
await page.waitForSelector('[data-size="51"]', {

Check failure on line 21 in e2e/react/src/routes/handle/test.ts

GitHub Actions / End-to-End Tests (ubuntu-latest, e2e-react)

src/routes/handle/test.ts:6:1 › handle fetch remembers server-side variables

1) src/routes/handle/test.ts:6:1 › handle fetch remembers server-side variables ────────────────── TimeoutError: page.waitForSelector: Timeout 1000ms exceeded. Call log: - waiting for locator('[data-size="51"]') to be visible 19 | // load the larger image and wait for it to resolve 20 | await page.click('#larger') > 21 | await page.waitForSelector('[data-size="51"]', { | ^ 22 | timeout: 1000, 23 | }) 24 | at /home/runner/work/houdini/houdini/e2e/react/src/routes/handle/test.ts:21:13
timeout: 1000,
})
}
// the value in the last row should be 'optimistic value 1'
expect(await getValue()).toBe('optimistic value 1')

Check failure on line 19 in e2e/react/src/routes/optimistic-keys/test.ts

GitHub Actions / End-to-End Tests (ubuntu-latest, e2e-react)

src/routes/optimistic-keys/test.ts:6:1 › @optimisticKey

2) src/routes/optimistic-keys/test.ts:6:1 › @optimisticKey ─────────────────────────────────────── Error: expect(received).toBe(expected) // Object.is equality Expected: "optimistic value 1" Received: "https://variety.com/wp-content/uploads/2022/03/Bruce-Willis.jpg?w=1000&h=562&crop=1" 17 | 18 | // the value in the last row should be 'optimistic value 1' > 19 | expect(await getValue()).toBe('optimistic value 1') | ^ 20 | 21 | // click on the last list in the row 22 | await page.click('[data-test-action="update"]') at /home/runner/work/houdini/houdini/e2e/react/src/routes/optimistic-keys/test.ts:19:27
// click on the last list in the row
await page.click('[data-test-action="update"]')