Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where JSON error response might get treated as non-JSON error response #1407

Merged
merged 9 commits into from
Jan 8, 2025
Merged

Fix bug where JSON error response might get treated as non-JSON error response #1407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2d1d1a0
Give better error when receiving non-JSON response
Mtn-View Dec 17, 2024
8baa209
Create changeset
Mtn-View Dec 17, 2024
1820f5a
Fix typo in changeset
Mtn-View Dec 17, 2024
e463f1e
Give more descriptive error when receiving non-JSON response
Mtn-View Dec 17, 2024
398f4f2
Fix typo in error message
Mtn-View Dec 17, 2024
d723d9a
Merge remote-tracking branch 'upstream/main'
Mtn-View Jan 7, 2025
7bed49b
Fix bug where JSON response might get treated as non-JSON
Mtn-View Jan 7, 2025
45f60a5
Delete .changeset/fluffy-lamps-provide.md
Mtn-View Jan 7, 2025
9892ef3
Fix conditional
Mtn-View Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tough-insects-joke.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'houdini': patch
---

Fix error bug JSON response might get treated as non-JSON if it includes `charset` or `boundary`
4 changes: 2 additions & 2 deletions packages/houdini/src/runtime/client/plugins/fetch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ const defaultFetch = (
// Avoid parsing the response if it's not JSON, as that will throw a SyntaxError
if (
!result.ok &&
result.headers.get('content-type') !== 'application/json' &&
result.headers.get('content-type') !== 'application/graphql+json'
!result.headers.get('content-type')?.startsWith('application/json') &&
!result.headers.get('content-type')?.startsWith('application/graphql+json')
) {
throw new Error(
`Failed to fetch: server returned invalid response with error ${result.status}: ${result.statusText}`
Expand Down
Loading