Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: OPTIC-1270: Remove Stale Feature Flag - fflag_feat_front_prod_309_choice_hint_080523_short #6576

Conversation

luarmr
Copy link
Contributor

@luarmr luarmr commented Oct 29, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

Removing a feature flag that has been stale for a while allows us to remove another feature flag that appears to be related in LD.

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit a48fe3a
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/67215528339d6c0008647f51

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit a48fe3a
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/67215528b98eed0008877ebd

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.73%. Comparing base (70a008f) to head (a48fe3a).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6576   +/-   ##
========================================
  Coverage    76.72%   76.73%           
========================================
  Files          169      169           
  Lines        13818    13818           
========================================
+ Hits         10602    10603    +1     
+ Misses        3216     3215    -1     
Flag Coverage Δ
pytests 76.73% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luarmr luarmr merged commit 5a90f67 into develop Oct 30, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants