Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: OPTIC-1270: Remove Stale Feature Flag - fflag_feat_front_prod_309_choice_hint_080523_short #6576

Merged
merged 1 commit into from
Oct 30, 2024
Merged

refactor: OPTIC-1270: Remove Stale Feature Flag - fflag_feat_front_prod_309_choice_hint_080523_short #6576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion label_studio/core/feature_flags/stale_feature_flags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
'fflag_fix_back_lsdv_4648_annotator_filter_29052023_short': True,
'fflag_feat_back_lsdv_5035_use_created_at_from_draft_for_annotation_256052023_short': True,
'fflag_feat_front_lsdv_3025_outliner_filter_short': False,
'fflag_feat_front_prod_309_choice_hint_080523_short': True,
'fflag_fix_front_lsdv_4992_hide_all_regions_04052023_short': True,
'ff_back_dev_4664_remove_storage_file_on_export_delete_29032023_short': False,
'fflag_feat_front_lops_86_datasets_storage_edit_short': False,
Expand Down
4 changes: 1 addition & 3 deletions web/libs/editor/src/components/Taxonomy/Taxonomy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { LsChevron } from "../../assets/icons";
import { Tooltip } from "../../common/Tooltip/Tooltip";
import { useToggle } from "../../hooks/useToggle";
import type { CNTagName } from "../../utils/bem";
import { FF_DEV_4075, FF_PROD_309, isFF } from "../../utils/feature-flags";
import { FF_DEV_4075, isFF } from "../../utils/feature-flags";
import { isArraysEqual } from "../../utils/utilities";
import TreeStructure from "../TreeStructure/TreeStructure";

Expand Down Expand Up @@ -160,8 +160,6 @@ type HintTooltipProps = {
};

export const HintTooltip: React.FC<HintTooltipProps> = ({ title, wrapper: Wrapper, children, ...rest }) => {
if (!isFF(FF_PROD_309)) return children;

const content = Wrapper ? <Wrapper>{children}</Wrapper> : children;

if (title) {
Expand Down
4 changes: 2 additions & 2 deletions web/libs/editor/src/tags/control/Choice.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import Tree from "../../core/Tree";
import Types from "../../core/Types";
import { AnnotationMixin } from "../../mixins/AnnotationMixin";
import { TagParentMixin } from "../../mixins/TagParentMixin";
import { FF_DEV_3391, FF_PROD_309, isFF } from "../../utils/feature-flags";
import { FF_DEV_3391, isFF } from "../../utils/feature-flags";
import { Block, Elem } from "../../utils/bem";
import "./Choice/Choice.scss";
import { LsChevron } from "../../assets/icons";
Expand Down Expand Up @@ -54,7 +54,7 @@ const TagAttrs = types.model({
style: types.maybeNull(types.string),
html: types.maybeNull(types.string),
color: types.maybeNull(types.string),
...(isFF(FF_PROD_309) ? { hint: types.maybeNull(types.string) } : {}),
hint: types.maybeNull(types.string),
});

const Model = types
Expand Down
5 changes: 0 additions & 5 deletions web/libs/editor/src/utils/feature-flags.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,11 +228,6 @@ export const FF_LSDV_4992 = "fflag_fix_front_lsdv_4992_hide_all_regions_04052023
*/
export const FF_LSDV_4998 = "fflag_fix_front_lsdv_4998_missed_dynamic_children_030523_short";

/**
* Add ability to show hints while hover over the choice
*/
export const FF_PROD_309 = "fflag_feat_front_prod_309_choice_hint_080523_short";

/**
* Fix delay on double-click interactions in Image Segmentation
* @link https://app.launchdarkly.com/default/production/features/fflag_fix_front_lsdv_5248_double_click_delay_280823_short
Expand Down
1 change: 0 additions & 1 deletion web/libs/editor/tests/integration/feature-flags.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as FLAGS from "../../src/utils/feature-flags";

export const CURRENT_FLAGS = {
[FLAGS.FF_DEV_1170]: true,
[FLAGS.FF_PROD_309]: true,
[FLAGS.FF_LSDV_4930]: true,
[FLAGS.FF_LSDV_4992]: true,
[FLAGS.FF_DEV_2715]: true,
Expand Down
Loading