fix: BROS-78: Fix Taxonomy in Preview #7881
Conversation
When you create project and use Taxonomy in a config, it has no dropdown, making preview for taxonomy useless in this dialog. It's good in Labeling Settings thought. The reason for this is z-index for Create Project dialog which is 2000. Making `z-index` bigger for Taxonomy dropdown solves the problem.
If you add Taxonomy to your config in Preview or edit config with Taxonomy in it, most likely you'll see "No more annotations" info block instead of preview. This is happening because of wrong usage of lazy reference in SharedChoiceMixin in `afterCreate()` - it should attach store to a tag when reference is missing, but it fails upon access. Using recommended `tryReference()` makes it safe and fixes the original issue.
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/git merge
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #7881 +/- ##
===========================================
- Coverage 70.21% 65.88% -4.33%
===========================================
Files 715 504 -211
Lines 50292 33377 -16915
Branches 8589 8589
===========================================
- Hits 35312 21992 -13320
+ Misses 14977 11382 -3595
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/git merge
|
|
/git merge
|
|
/git merge
|
|
/git merge
|
There are two issues in Taxonomy in Preview:
1. Dropdown is not visible
taxonomy-preview-1-dropdown.mov
When you create project and use Taxonomy in a config, it has no dropdown, making preview for taxonomy useless in this dialog.
It's good in Labeling Settings thought.
The reason for this is z-index for Create Project dialog is 2000 while z-index for antd dropdown is 1050. Making
z-indexfor Taxonomy dropdown above 2000 solves the problem.2. "No more annotations"
taxonomy-preview-2-no-more.mov
If you add Taxonomy to your config in Preview or edit config with Taxonomy in it, most likely you'll see "No more annotations" info block instead of preview.
This is happening because of wrong usage of lazy reference in SharedChoiceMixin in
afterCreate()- it should attach store to a tag when reference is missing, but it fails upon access. Using recommendedtryReference()makes it safe and fixes the original issue.What's left