Skip to content

fix: BROS-78: Fix Taxonomy in Preview #7881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
:global(.htx-taxonomy-item-color) {
padding: 4px;
border-radius: 2px;
}
}

// increase specificity to override usual .ant-select-dropdown z-index
:global(.htx-taxonomy-dropdown.ant-select-dropdown) {
// Create Project popup has 2000
z-index: 3000;
}
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ const NewTaxonomy = ({
placeholder={options.placeholder || "Click to add..."}
style={style}
className="htx-taxonomy"
popupClassName="htx-taxonomy-dropdown"
disabled={!isEditable}
/>
);
Expand Down
8 changes: 5 additions & 3 deletions web/libs/editor/src/mixins/SharedChoiceStore/mixin.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { types } from "mobx-state-tree";
import { tryReference, types } from "mobx-state-tree";
import Types from "../../core/Types";
import { SharedStoreModel } from "./model";

Expand Down Expand Up @@ -30,7 +30,7 @@ const Store = types.optional(types.maybeNull(types.late(() => types.reference(Sh
*
* It was specifically designed to be used with Repeater tag where the memory issues are the most sound.
*
* This mixin provedes a `sharedStore` property to the model which is a reference to the shared store.
* This mixin provides a `sharedStore` property to the model which is a reference to the shared store.
*
* The concept behind it is that whenever a model is parsing a snapshot, children are subtracted from the
* initial snapshot, and put into the newly created SharedStore.
Expand Down Expand Up @@ -73,7 +73,9 @@ export const SharedStoreMixin = types
}))
.actions((self) => ({
afterCreate() {
if (!self.store) {
const currentStore = tryReference(() => self.store);

if (!currentStore) {
const store = Stores.get(self.storeId);
const annotationStore = Types.getParentOfTypeString(self, "AnnotationStore");

Expand Down
Loading