[Fix] play.py cannot override agent_cfg from command line argument #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After Hydra integration to
play.py, the agent configuration is already built from the entry-point yaml and updated with any command-line overrides.However, the legacy call to
parse_rsl_rl_cfgis still executed inside main, which discards the Hydra-supplied config and rebuilds it from scratch, losing all overrides.Fix
Replace the redundant
parse_rsl_rl_cfgwithupdate_rsl_rl_cfg, which only patches the already-constructed config with CLI flags that are not managed by Hydra (e.g. checkpoint path).This guarantees that Hydra’s command-line overrides are preserved while keeping the extra CLI tweaks intact.
Original Code:
Corrected Code: