Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Add mac arm64 runner #574

Merged
merged 7 commits into from
Oct 6, 2023
Merged

[CI] Add mac arm64 runner #574

merged 7 commits into from
Oct 6, 2023

Conversation

BrettCleary
Copy link
Collaborator

@BrettCleary BrettCleary commented Oct 5, 2023 •
edited
Loading

Build arm64 mac on a m1 runner to fix bytecode error

This uses a manual trigger to save $. Once it is merged main you will be able to manually trigger for any branch here https://github.com/HyperPlay-Gaming/hyperplay-desktop-client/actions/workflows/build-mac-arm64.yml

Testing

  1. Verify the error from 0.7.1 on m1
  2. Download mac-dmg-arm64 https://github.com/HyperPlay-Gaming/hyperplay-desktop-client/actions/runs/6424604877?pr=574
  3. Sign the app with xattr -r -d com.apple.quarantine /Applications/HyperPlay.app
  4. Verify the app launches without error

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@BrettCleary BrettCleary added PR: Ready-For-Review PR is ready to be reviewed by peers PR: Ready-For-Test PR is ready to be tested by a QA and removed PR: WIP labels Oct 5, 2023
@BrettCleary BrettCleary self-assigned this Oct 5, 2023
flavioislima
flavioislima approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Cool that github finally added a M1 image.

eliobricenov
eliobricenov approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@eliobricenov eliobricenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BrettCleary BrettCleary merged commit ef7fae6 into main Oct 6, 2023
@BrettCleary BrettCleary deleted the ci/arm64_runner branch October 6, 2023 00:10
@BrettCleary BrettCleary mentioned this pull request Feb 22, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliobricenov eliobricenov eliobricenov approved these changes

@flavioislima flavioislima flavioislima approved these changes

@nyghtstalker nyghtstalker Awaiting requested review from nyghtstalker

Assignees

@BrettCleary BrettCleary

Labels
PR: Ready-For-Review PR is ready to be reviewed by peers PR: Ready-For-Test PR is ready to be tested by a QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrettCleary @flavioislima @eliobricenov