Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Containment based queries optimized #537

Merged
merged 20 commits into from
Jul 16, 2023
Merged

Containment based queries optimized #537

merged 20 commits into from
Jul 16, 2023

Commits on Jun 20, 2023

  1. Optimized implementation of EquivalenceQuery. 

    Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    773fb84 View commit details
    Browse the repository at this point in the history

  2. Added VacuityQuery and RedundancyQuery optimized implementation. 

    Keeping optimized properties separated per rule (instead of the union of all policy rules)
Fixed handling HostEPs in optimized implementation.

Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    c5bf934 View commit details
    Browse the repository at this point in the history

  3. Added VacuityQuery and RedundancyQuery optimized implementation. 

    Keeping optimized properties separated per rule (instead of the union of all policy rules)
Fixed handling HostEPs in optimized implementation.

Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    aab6396 View commit details
    Browse the repository at this point in the history

  4. Ignoring 'complex function' lint error. 

    Returning 'passed' code for skipped queries.

Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    54d3343 View commit details
    Browse the repository at this point in the history

  5. Added VacuityQuery and RedundancyQuery optimized implementation. 

    Keeping optimized properties separated per rule (instead of the union of all policy rules)
Fixed handling HostEPs in optimized implementation.

Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    adba6dd View commit details
    Browse the repository at this point in the history

  6. Removed redundant method. 

    Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    ab3a82e View commit details
    Browse the repository at this point in the history

  7. Added VacuityQuery and RedundancyQuery optimized implementation. 

    Keeping optimized properties separated per rule (instead of the union of all policy rules)
Fixed handling HostEPs in optimized implementation.

Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    c9393ee View commit details
    Browse the repository at this point in the history

  8. Fixed domain updating mechanism per rule (to avoid activating multipl… 

    …e times for the same rule, for example when a rule appears twice in a config).

Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    da98a3f View commit details
    Browse the repository at this point in the history

  9. Fixed lint errors 

    Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    9cd810e View commit details
    Browse the repository at this point in the history

  10. Enabled strongEquivalence optimized implementation. 

    Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    ac4f679 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2023

  1. Implemented optimized ContainmentQuery. 

    Commented out containment fullExplanation result comparison in tests, since optimized solution gives more accurate result that differs from the original expected result, and thus the test fails.

Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    cbe8d1f View commit details
    Browse the repository at this point in the history

  2. Enabled optimized TwoContainmentQuery and PermitsQuery. 

    Commented out twoWayContainment fullExplanation result comparison in tests, since optimized solution gives more accurate result that differs from the original expected result, and thus the tests fail.

Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    ac38097 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. Fixed small inaccuracy in handling host endpoints in optimized solution. 

    Adding docs

Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    6e632b5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'equivalence-based-queries-optmized' into containment-ba… 

    …sed-queries-optmized
    @tanyaveksler
    tanyaveksler committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    af4c84f View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. Merge with master. 

    Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    a5ef8b8 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2023

  1. Merge branch 'master' into containment-based-queries-optmized

    @tanyaveksler
    tanyaveksler authored Jul 9, 2023
    Configuration menu
    Copy the full SHA
    4682ee7 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Merge branch 'master' into containment-based-queries-optmized

    @tanyaveksler
    tanyaveksler authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    23188ae View commit details
    Browse the repository at this point in the history

  2. Protecting optimized props policy members from direct access; accessi… 

    …ng only by 'getter' methods, to ensure sync is called before access.

Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    b1cf11f View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2023

  1. Added implemented queries to run_all_tests.py 

    Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    e507368 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into containment-based-queries-optmized

    @tanyaveksler
    tanyaveksler authored Jul 16, 2023
    Configuration menu
    Copy the full SHA
    0dd276a View commit details
    Browse the repository at this point in the history