Semantic diff query optimized #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tanya <[email protected]>
Keeping optimized properties separated per rule (instead of the union of all policy rules) Fixed handling HostEPs in optimized implementation. Signed-off-by: Tanya <[email protected]>
Keeping optimized properties separated per rule (instead of the union of all policy rules) Fixed handling HostEPs in optimized implementation. Signed-off-by: Tanya <[email protected]>
Returning 'passed' code for skipped queries. Signed-off-by: Tanya <[email protected]>
Keeping optimized properties separated per rule (instead of the union of all policy rules) Fixed handling HostEPs in optimized implementation. Signed-off-by: Tanya <[email protected]>
Signed-off-by: Tanya <[email protected]>
Keeping optimized properties separated per rule (instead of the union of all policy rules) Fixed handling HostEPs in optimized implementation. Signed-off-by: Tanya <[email protected]>
…e times for the same rule, for example when a rule appears twice in a config). Signed-off-by: Tanya <[email protected]>
Signed-off-by: Tanya <[email protected]>
Signed-off-by: Tanya <[email protected]>
Commented out containment fullExplanation result comparison in tests, since optimized solution gives more accurate result that differs from the original expected result, and thus the test fails. Signed-off-by: Tanya <[email protected]>
Commented out twoWayContainment fullExplanation result comparison in tests, since optimized solution gives more accurate result that differs from the original expected result, and thus the tests fail. Signed-off-by: Tanya <[email protected]>
Adding docs Signed-off-by: Tanya <[email protected]>
…sed-queries-optmized
Signed-off-by: Tanya <[email protected]>
Signed-off-by: Tanya <[email protected]>
Commenting out detailed difference result for some tests, since optimized implementation results are sometimes more detailed than the original ones. Signed-off-by: Tanya <[email protected]>
Signed-off-by: Tanya <[email protected]>
Signed-off-by: Tanya <[email protected]>
…ctions. Signed-off-by: Tanya <[email protected]>
Adding implemented queries also to run_all_tests.py Signed-off-by: Tanya <[email protected]>
Signed-off-by: Tanya <[email protected]>
Signed-off-by: Tanya <[email protected]>
…dded semantic comparison of original and optimized results, and returning original result (to avoid test failures). In case of optimized_run == 'true' returning optimized result. Signed-off-by: Tanya <[email protected]>
Signed-off-by: Tanya <[email protected]>
Signed-off-by: Tanya <[email protected]>
… debug mode. In optimized run, extracting referenced ip-blocks from connectivity properties. Signed-off-by: Tanya <[email protected]>
Signed-off-by: Tanya <[email protected]>
Signed-off-by: Tanya <[email protected]>
adisos
reviewed
Aug 5, 2023
Co-authored-by: Adi Sosnovich <[email protected]>
Signed-off-by: Tanya <[email protected]>
In filter_conns_by_input_or_internal_constraints, computing ip_block_mask only when exclude_ipv6 flag is true. Signed-off-by: Tanya <[email protected]>
Signed-off-by: Tanya <[email protected]>
Signed-off-by: Tanya <[email protected]>
Signed-off-by: Tanya <[email protected]>
Signed-off-by: Tanya <[email protected]>
adisos
reviewed
Aug 14, 2023
| @@ -812,7 +832,7 @@ def compute_connectivity_output_optimized(self): | |||
| ref_ip_blocks = self.config.get_referenced_ip_blocks(exclude_ipv6) | |||
| for ip_block in ref_ip_blocks: | |||
| ip_blocks_mask |= ip_block | |||
| opt_peers_to_compare.filter_ipv6_blocks(ip_blocks_mask) | |||
| opt_peers_to_compare.filter_ip_blocks_by_mask(ip_blocks_mask) | |||
There was a problem hiding this comment.
can't the arg to filter_ip_blocks_by_mask just be IpBlock.get_all_ips_block(exclude_ipv6=True) instead of ip_blocks_mask ? (and use the function check_for_excluding_ipv6_addresses() instead of using self.output_config.excludeIPv6Range )?
There was a problem hiding this comment.
Right, changed similarly to TwoNetworkConfigsQuery.filter_conns_by_input_or_internal_constraints
There was a problem hiding this comment.
opened issue #594 related to follow-ups for the ipv6 filtering aspects.
Co-authored-by: Adi Sosnovich <[email protected]>
Signed-off-by: Tanya <[email protected]>
…(whenever at least one Ipv6 block appears in any policy in the config, none of IPv6 blocks will be filtered out). Signed-off-by: Tanya <[email protected]>
adisos
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.