Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semantic diff query optimized #577

Merged
merged 46 commits into from
Sep 12, 2023
Merged

Semantic diff query optimized #577

merged 46 commits into from
Sep 12, 2023

Commits on Jun 20, 2023

  1. Optimized implementation of EquivalenceQuery. 

    Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    773fb84 View commit details
    Browse the repository at this point in the history

  2. Added VacuityQuery and RedundancyQuery optimized implementation. 

    Keeping optimized properties separated per rule (instead of the union of all policy rules)
Fixed handling HostEPs in optimized implementation.

Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    c5bf934 View commit details
    Browse the repository at this point in the history

  3. Added VacuityQuery and RedundancyQuery optimized implementation. 

    Keeping optimized properties separated per rule (instead of the union of all policy rules)
Fixed handling HostEPs in optimized implementation.

Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    aab6396 View commit details
    Browse the repository at this point in the history

  4. Ignoring 'complex function' lint error. 

    Returning 'passed' code for skipped queries.

Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    54d3343 View commit details
    Browse the repository at this point in the history

  5. Added VacuityQuery and RedundancyQuery optimized implementation. 

    Keeping optimized properties separated per rule (instead of the union of all policy rules)
Fixed handling HostEPs in optimized implementation.

Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    adba6dd View commit details
    Browse the repository at this point in the history

  6. Removed redundant method. 

    Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    ab3a82e View commit details
    Browse the repository at this point in the history

  7. Added VacuityQuery and RedundancyQuery optimized implementation. 

    Keeping optimized properties separated per rule (instead of the union of all policy rules)
Fixed handling HostEPs in optimized implementation.

Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    c9393ee View commit details
    Browse the repository at this point in the history

  8. Fixed domain updating mechanism per rule (to avoid activating multipl… 

    …e times for the same rule, for example when a rule appears twice in a config).

Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    da98a3f View commit details
    Browse the repository at this point in the history

  9. Fixed lint errors 

    Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    9cd810e View commit details
    Browse the repository at this point in the history

  10. Enabled strongEquivalence optimized implementation. 

    Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    ac4f679 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2023

  1. Implemented optimized ContainmentQuery. 

    Commented out containment fullExplanation result comparison in tests, since optimized solution gives more accurate result that differs from the original expected result, and thus the test fails.

Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    cbe8d1f View commit details
    Browse the repository at this point in the history

  2. Enabled optimized TwoContainmentQuery and PermitsQuery. 

    Commented out twoWayContainment fullExplanation result comparison in tests, since optimized solution gives more accurate result that differs from the original expected result, and thus the tests fail.

Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    ac38097 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. Fixed small inaccuracy in handling host endpoints in optimized solution. 

    Adding docs

Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    6e632b5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'equivalence-based-queries-optmized' into containment-ba… 

    …sed-queries-optmized
    @tanyaveksler
    tanyaveksler committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    af4c84f View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2023

  1. Implemented optimized InterferesQuery 

    Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    a6ef67c View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2023

  1. Merge with master 

    Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    959d741 View commit details
    Browse the repository at this point in the history

  2. Small improvement in print differences for two config queries 

    Commenting out detailed difference result for some tests, since optimized implementation results are sometimes more detailed than the original ones.

Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    3cd1578 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Merge branch 'master' into interferes-based-queries-optimized

    @tanyaveksler
    tanyaveksler authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    951b40c View commit details
    Browse the repository at this point in the history

  2. Optimized implementation of intersects and forbids queries. 

    Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    5b21d04 View commit details
    Browse the repository at this point in the history

  3. Fixed bug in creation of optimized istio policy properties. 

    Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    2b6b13b View commit details
    Browse the repository at this point in the history

  4. Opened for optimized run those queries that do not call allowed_conne… 

    …ctions.

Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    3d840a4 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2023

  1. Merge with master. 

    Adding implemented queries also to run_all_tests.py

Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    a68de7e View commit details
    Browse the repository at this point in the history

  2. Implemented sanity query optimized. 

    Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    22b8f2c View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Implemented optimized semantic diff query. 

    Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    35e8a74 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Change in semantic diff query: in case of optimized_run == 'debug', a… 

    …dded semantic comparison of original and optimized results, and returning original result (to avoid test failures).

In case of optimized_run == 'true' returning optimized result.

Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    08b6b10 View commit details
    Browse the repository at this point in the history

  2. Small fix 

    Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    fc643da View commit details
    Browse the repository at this point in the history

  3. Merge with master 

    Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    054aaf6 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2023

  1. Improving output of comparison between original and optimized runs in… 

    … debug mode.

In optimized run, extracting referenced ip-blocks from connectivity properties.

Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    bd22ab9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into semantic-diff-query-optimized

    @tanyaveksler
    tanyaveksler committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    fc6eaba View commit details
    Browse the repository at this point in the history

  3. Fixing handling ipv6 blocks in optimized run. 

    Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    ed791e1 View commit details
    Browse the repository at this point in the history

  4. Fixing lint errors 

    Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    4867e95 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2023

  1. Update nca/FWRules/ConnectivityGraph.py 

    Co-authored-by: Adi Sosnovich <[email protected]>
    @tanyaveksler @adisos
    tanyaveksler and adisos authored Aug 6, 2023
    Configuration menu
    Copy the full SHA
    a4e14b0 View commit details
    Browse the repository at this point in the history

  2. merge with master 

    Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    2fd82da View commit details
    Browse the repository at this point in the history

  3. Avoid using redundant all_peers (using inactive dimension instead). 

    In filter_conns_by_input_or_internal_constraints, computing ip_block_mask only when exclude_ipv6 flag is true.

Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    8967e2b View commit details
    Browse the repository at this point in the history

  4. Simplified filtering of ipv6 blocks 

    Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    abb2fbe View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Fixed lint warnings. 

    Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    e69b417 View commit details
    Browse the repository at this point in the history

  2. merge with master 

    Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    1caf9ce View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into semantic-diff-query-optimized

    @tanyaveksler
    tanyaveksler committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    6219813 View commit details
    Browse the repository at this point in the history

  4. Optimized filtering IpBlocks by mask. 

    Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    9c77ec5 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Merge branch 'master' into semantic-diff-query-optimized

    @tanyaveksler
    tanyaveksler authored Aug 15, 2023
    Configuration menu
    Copy the full SHA
    22cefcb View commit details
    Browse the repository at this point in the history

  2. Update nca/CoreDS/Peer.py 

    Co-authored-by: Adi Sosnovich <[email protected]>
    @tanyaveksler @adisos
    tanyaveksler and adisos authored Aug 15, 2023
    Configuration menu
    Copy the full SHA
    d321200 View commit details
    Browse the repository at this point in the history

  3. Fixed filtering IpBlocks by mask in ConnectivityMapQuery 

    Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    334ba10 View commit details
    Browse the repository at this point in the history

  4. Refined filtering of IPv6 blocks in original and optimized solutions … 

    …(whenever at least one Ipv6 block appears in any policy in the config, none of IPv6 blocks will be filtered out).

Signed-off-by: Tanya <[email protected]>
    @tanyaveksler
    tanyaveksler committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    55ddd55 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2023

  1. Merge branch 'master' into semantic-diff-query-optimized

    @tanyaveksler
    tanyaveksler authored Aug 20, 2023
    Configuration menu
    Copy the full SHA
    13cdc5a View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Merge branch 'master' into semantic-diff-query-optimized

    @tanyaveksler
    tanyaveksler authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    b24d06d View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Merge branch 'master' into semantic-diff-query-optimized

    @tanyaveksler
    tanyaveksler authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    e3cbd0f View commit details
    Browse the repository at this point in the history