Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HC optimization finalization - phase 3 #723

Merged
merged 96 commits into from
Jun 9, 2024
Merged

HC optimization finalization - phase 3 #723

merged 96 commits into from
Jun 9, 2024

Conversation

tanyaveksler
Copy link
Member

Benchmarking optimized vs. non-optimized implementation. Fixing long runs.
Cleaning up non-optimized code.

Signed-off-by: Tanya <[email protected]>
…ding to more condensed optimized output.

Signed-off-by: Tanya <[email protected]>
…to account TCP/non-TCP protocol restriction.

Signed-off-by: Tanya <[email protected]>
…ther, according to grouping in cubes). Also, added grouping by labels to initial grouping.

Signed-off-by: Tanya <[email protected]>
…ther, according to grouping in cubes). Also, added grouping by labels to initial grouping.

Signed-off-by: Tanya <[email protected]>
Signed-off-by: Tanya <[email protected]>
…e properties in containing connections.

Signed-off-by: Tanya <[email protected]>
Refined ns-set pairs grouping computation -trying starting from src_peers and from dst_peers and choosing a more compact grouping.
Added grouping by full IpBlock.

Signed-off-by: Tanya <[email protected]>
Signed-off-by: Tanya <[email protected]>
Signed-off-by: Tanya <[email protected]>
…neration of dot output in optimized solution

Signed-off-by: Tanya <[email protected]>
… optimized fw-rules minimization algorithm.

Fixed get_connection_set_and_peers_from_cube.
Changed some of the expected results of semantic diff tests.

Signed-off-by: Tanya <[email protected]>
Updated more semantic diff expected results.

Signed-off-by: Tanya <[email protected]>
…les minimization) only if the number of peers is not too high, to avoid long run of these auto-connections calculation.

Signed-off-by: Tanya <[email protected]>
…in test schemes (instead of putting them only in configurations), to avoid trying to load resources from live cluster, which is time-consuming.

Signed-off-by: Tanya <[email protected]>
@tanyaveksler tanyaveksler self-assigned this May 5, 2024
Changed number of expected warnings (see Issue #724

Signed-off-by: Tanya <[email protected]>
Fixed small error.

Signed-off-by: Tanya <[email protected]>
Consequently, fixed expected results

Signed-off-by: Tanya <[email protected]>
Small fix in printing TCP connections in dot format.

Signed-off-by: Tanya <[email protected]>
Signed-off-by: Tanya <[email protected]>
…tivityProperties.

Removed outdated unit tests.

Signed-off-by: Tanya <[email protected]>
Signed-off-by: Tanya <[email protected]>
@tanyaveksler tanyaveksler requested a review from adisos May 21, 2024 16:25
Removed --optimized_run flag.
Removed ConnectionSet class.

Signed-off-by: Tanya <[email protected]>
Removed original-to-optimized-comparison workflows from test-push.

Signed-off-by: Tanya <[email protected]>
Signed-off-by: Tanya <[email protected]>
Signed-off-by: Tanya <[email protected]>
Signed-off-by: Tanya <[email protected]>
Copy link
Member

@adisos adisos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanyaveksler tanyaveksler merged commit 0c27129 into master Jun 9, 2024
12 checks passed
@tanyaveksler tanyaveksler deleted the opt-finalize3 branch June 9, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants