Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HC optimization finalization - phase 3 #723

Merged
merged 96 commits into from
Jun 9, 2024
Merged

HC optimization finalization - phase 3 #723

merged 96 commits into from
Jun 9, 2024

Commits on Feb 25, 2024

  1. Initial implementation of building and minimizing fw-rules directly f…

    …rom connectivity properties.
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    8e368e0 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2024

  1. Fixed lint errors.

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    8240404 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5ad1ee9 View commit details
    Browse the repository at this point in the history
  3. Updating (some of) expected results for explainability queries, accor…

    …ding to more condensed optimized output.
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    6466889 View commit details
    Browse the repository at this point in the history
  4. Fixed converting fw-rules to connectivity properties, while taking in…

    …to account TCP/non-TCP protocol restriction.
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    a615f5c View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2024

  1. Configuration menu
    Copy the full SHA
    9c5e89a View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2024

  1. Optimized initial namespace grouping (by grouping few namespaces toge…

    …ther, according to grouping in cubes). Also, added grouping by labels to initial grouping.
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    81ac68f View commit details
    Browse the repository at this point in the history
  2. Optimized initial namespace grouping (by grouping few namespaces toge…

    …ther, according to grouping in cubes). Also, added grouping by labels to initial grouping.
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    06f5250 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Configuration menu
    Copy the full SHA
    898f222 View commit details
    Browse the repository at this point in the history
  2. Fixed lint error

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    ae2ff0a View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2024

  1. Refining basic namespace grouping by finding more opportunities to us…

    …e properties in containing connections.
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    06b2905 View commit details
    Browse the repository at this point in the history
  2. One more refinemenet of basic namespace grouping

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    6b22688 View commit details
    Browse the repository at this point in the history
  3. One more refinemenet of basic namespace grouping

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    368f1b0 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Configuration menu
    Copy the full SHA
    d027631 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8b343d6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0bb3094 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2024

  1. Added outputEndpoints option handling to PeerSetElement.

    Refined ns-set pairs grouping computation -trying starting from src_peers and from dst_peers and choosing a more compact grouping.
    Added grouping by full IpBlock.
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    0df3938 View commit details
    Browse the repository at this point in the history
  2. Fixing lint errors.

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    4db0e43 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Configuration menu
    Copy the full SHA
    757a684 View commit details
    Browse the repository at this point in the history
  2. Fixing lint error

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    1efde22 View commit details
    Browse the repository at this point in the history
  3. Fix: taking into account connectivity restriction (TCP/non-TCP) in ge…

    …neration of dot output in optimized solution
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    86af435 View commit details
    Browse the repository at this point in the history
  4. Small fixes in txt_no_fw_rules_format

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    8bd2944 View commit details
    Browse the repository at this point in the history
  5. Small fixes in txt_no_fw_rules_format

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    0bd08c3 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2024

  1. Configuration menu
    Copy the full SHA
    b01e93d View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Changed expected results of connectivity map query tests according to…

    … optimized runs
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    316dee1 View commit details
    Browse the repository at this point in the history
  2. Changed optimized semantic diff query implementation according to the…

    … optimized fw-rules minimization algorithm.
    
    Fixed get_connection_set_and_peers_from_cube.
    Changed some of the expected results of semantic diff tests.
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    e5eb701 View commit details
    Browse the repository at this point in the history
  3. Keeping every dns entry separate in minimization of fw rules.

    Updated more semantic diff expected results.
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    5c0cc0c View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2024

  1. Configuration menu
    Copy the full SHA
    f8f1d67 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eaf561d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d6633e4 View commit details
    Browse the repository at this point in the history
  4. Fixed lint error.

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    100df6a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6fc8221 View commit details
    Browse the repository at this point in the history
  6. Changed default to be the optimized run.

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    b578147 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3d35da6 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4a70d30 View commit details
    Browse the repository at this point in the history
  9. Updating more expected results.

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    f382c5e View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Small optimizations.

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    d4956a0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d3dafb1 View commit details
    Browse the repository at this point in the history
  3. Initial implementation of building and minimizing fw-rules directly f…

    …rom connectivity properties.
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    c0b2ed1 View commit details
    Browse the repository at this point in the history
  4. Fixed lint errors.

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    bf949ff View commit details
    Browse the repository at this point in the history
  5. Updating (some of) expected results for explainability queries, accor…

    …ding to more condensed optimized output.
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    5532e4d View commit details
    Browse the repository at this point in the history
  6. Fixed converting fw-rules to connectivity properties, while taking in…

    …to account TCP/non-TCP protocol restriction.
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    6e05b88 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7a6f409 View commit details
    Browse the repository at this point in the history
  8. Optimized initial namespace grouping (by grouping few namespaces toge…

    …ther, according to grouping in cubes). Also, added grouping by labels to initial grouping.
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    51eb02b View commit details
    Browse the repository at this point in the history
  9. Optimized initial namespace grouping (by grouping few namespaces toge…

    …ther, according to grouping in cubes). Also, added grouping by labels to initial grouping.
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    fedb46f View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    79454db View commit details
    Browse the repository at this point in the history
  11. Fixed lint error

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    1d411e4 View commit details
    Browse the repository at this point in the history
  12. Refining basic namespace grouping by finding more opportunities to us…

    …e properties in containing connections.
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    11c15ff View commit details
    Browse the repository at this point in the history
  13. One more refinemenet of basic namespace grouping

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    e541498 View commit details
    Browse the repository at this point in the history
  14. One more refinemenet of basic namespace grouping

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    63c2eca View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    6fb48d3 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    4203525 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    62aa803 View commit details
    Browse the repository at this point in the history
  18. Added outputEndpoints option handling to PeerSetElement.

    Refined ns-set pairs grouping computation -trying starting from src_peers and from dst_peers and choosing a more compact grouping.
    Added grouping by full IpBlock.
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    70d2aaf View commit details
    Browse the repository at this point in the history
  19. Fixing lint errors.

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    a98798f View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    a5c9808 View commit details
    Browse the repository at this point in the history
  21. Fixing lint error

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    43d2e5b View commit details
    Browse the repository at this point in the history
  22. Fix: taking into account connectivity restriction (TCP/non-TCP) in ge…

    …neration of dot output in optimized solution
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    36edddf View commit details
    Browse the repository at this point in the history
  23. Small fixes in txt_no_fw_rules_format

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    91f13ff View commit details
    Browse the repository at this point in the history
  24. Small fixes in txt_no_fw_rules_format

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    55b2786 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    05de16f View commit details
    Browse the repository at this point in the history
  26. Changed expected results of connectivity map query tests according to…

    … optimized runs
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    9ad18b1 View commit details
    Browse the repository at this point in the history
  27. Changed optimized semantic diff query implementation according to the…

    … optimized fw-rules minimization algorithm.
    
    Fixed get_connection_set_and_peers_from_cube.
    Changed some of the expected results of semantic diff tests.
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    c11a3ae View commit details
    Browse the repository at this point in the history
  28. Keeping every dns entry separate in minimization of fw rules.

    Updated more semantic diff expected results.
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    f591e4f View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    5e5b1a4 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    5817b22 View commit details
    Browse the repository at this point in the history
  31. Fixed lint error.

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    1379379 View commit details
    Browse the repository at this point in the history
  32. Changed default to be the optimized run.

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    8a0d7f2 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    91a6298 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    7aaa0ba View commit details
    Browse the repository at this point in the history
  35. Updating more expected results.

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    f7cc420 View commit details
    Browse the repository at this point in the history
  36. Small optimizations.

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    43bb6f4 View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    0334ec1 View commit details
    Browse the repository at this point in the history
  38. Small optimizations.

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    d71e51f View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    cb54265 View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    e788779 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Optimization: adding auto-connections to covered_peer_props (in fw-ru…

    …les minimization) only if the number of peers is not too high, to avoid long run of these auto-connections calculation.
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    15d2c65 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2024

  1. Optimization: adding resources to global resource/namespace/pod list …

    …in test schemes (instead of putting them only in configurations), to avoid trying to load resources from live cluster, which is time-consuming.
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed May 5, 2024
    Configuration menu
    Copy the full SHA
    a26b179 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ef2596b View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Deleted unused original implementation code.

    Changed number of expected warnings (see Issue #724
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed May 7, 2024
    Configuration menu
    Copy the full SHA
    cc432e3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e9b1e7f View commit details
    Browse the repository at this point in the history

Commits on May 19, 2024

  1. Removed usage of ConnectionSet.

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed May 19, 2024
    Configuration menu
    Copy the full SHA
    511a634 View commit details
    Browse the repository at this point in the history
  2. Fixed lint errors.

    Fixed small error.
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed May 19, 2024
    Configuration menu
    Copy the full SHA
    8a443e8 View commit details
    Browse the repository at this point in the history
  3. Fixed sorting ConnectivityProperties (making stable sort)

    Consequently, fixed expected results
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed May 19, 2024
    Configuration menu
    Copy the full SHA
    340d755 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Fixed handling TCP / non-TCP connections output.

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed May 21, 2024
    Configuration menu
    Copy the full SHA
    204cea8 View commit details
    Browse the repository at this point in the history
  2. More fixed expected results.

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed May 21, 2024
    Configuration menu
    Copy the full SHA
    7bb7132 View commit details
    Browse the repository at this point in the history
  3. More fixed expected results.

    Small fix in printing TCP connections in dot format.
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed May 21, 2024
    Configuration menu
    Copy the full SHA
    3b30228 View commit details
    Browse the repository at this point in the history
  4. Added some doc

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed May 21, 2024
    Configuration menu
    Copy the full SHA
    b769096 View commit details
    Browse the repository at this point in the history
  5. Removed no longer used named_ports and excluded_named_ports in Connec…

    …tivityProperties.
    
    Removed outdated unit tests.
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed May 21, 2024
    Configuration menu
    Copy the full SHA
    c1dc05b View commit details
    Browse the repository at this point in the history
  6. Small fixes

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed May 21, 2024
    Configuration menu
    Copy the full SHA
    4926dd9 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2024

  1. Updates of some more expected results.

    Removed --optimized_run flag.
    Removed ConnectionSet class.
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    16869e8 View commit details
    Browse the repository at this point in the history
  2. Fixed lint errors.

    Removed original-to-optimized-comparison workflows from test-push.
    
    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    e7cd7ae View commit details
    Browse the repository at this point in the history
  3. Small fix.

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    1d3ffe1 View commit details
    Browse the repository at this point in the history
  4. Small fix.

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    1d9b1be View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Configuration menu
    Copy the full SHA
    13affc8 View commit details
    Browse the repository at this point in the history
  2. Fixed lint error.

    Signed-off-by: Tanya <[email protected]>
    tanyaveksler committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    019cf3e View commit details
    Browse the repository at this point in the history