Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version of Semsimian dependency and search functionality #645

Closed
wants to merge 22 commits into from

Conversation

hrshdhgd
Copy link
Collaborator

@hrshdhgd hrshdhgd commented Aug 25, 2023

  • Bumped semsimian version in toml + lock files.
  • Added code for associations_subject_search()
  • Test optimization.

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10% ⚠️

Comparison is base (8d2a124) 76.97% compared to head (a33264a) 76.88%.
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #645      +/-   ##
==========================================
- Coverage   76.97%   76.88%   -0.10%     
==========================================
  Files         247      250       +3     
  Lines       28643    29110     +467     
==========================================
+ Hits        22049    22380     +331     
- Misses       6594     6730     +136     
Files Changed Coverage Δ
src/oaklib/utilities/lexical/lexical_indexer.py 83.96% <ø> (ø)
...lementations/semsimian/semsimian_implementation.py 68.37% <100.00%> (+1.70%) ⬆️
...t_implementations/test_semsimian_implementation.py 90.47% <100.00%> (+2.67%) ⬆️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmungall
Copy link
Collaborator

this passes - is there remaining work before this goes draft->merge?

@hrshdhgd
Copy link
Collaborator Author

hrshdhgd commented Aug 25, 2023

I wanted to keep this branch to iterate over progressing versions of semsimian. The latest release candidate is based off this branch. I intend to merge this once we have a version of semsimian that has an acceptable runtime for termset_pairwise_similarity

@hrshdhgd hrshdhgd changed the title Latest version of Semsimian dependency. Latest version of Semsimian dependency and search functionality Aug 31, 2023
@cmungall
Copy link
Collaborator

I assume this work has been incorporated in another branch, reopen if necessary

@cmungall cmungall closed this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants