Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added change handler for kgcl.RemoveNodeFromSubset #783

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Added change handler for kgcl.RemoveNodeFromSubset #783

merged 3 commits into from
Jul 23, 2024

Conversation

hrshdhgd
Copy link
Collaborator

Previously non existent.

Triggered by: monarch-initiative/mondo#7962 (review)

@hrshdhgd hrshdhgd mentioned this pull request Jul 23, 2024
Merged
@hrshdhgd hrshdhgd requested a review from matentzn July 23, 2024 16:27
sierra-moxon
sierra-moxon approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@sierra-moxon sierra-moxon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the neat set + list comprehension here!

Tiny request: adding the expected type to the value method parameter would help me understand. Alternatively, a test to exercise it.

@hrshdhgd
Copy link
Collaborator Author

Thank you @sierra-moxon ! Working on it now..

@hrshdhgd hrshdhgd requested a review from sierra-moxon July 23, 2024 17:21
sierra-moxon
sierra-moxon approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@sierra-moxon sierra-moxon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Harshad!! :)

@hrshdhgd hrshdhgd merged commit 5bec328 into main Jul 23, 2024
9 checks passed
@hrshdhgd hrshdhgd deleted the remove-subset branch July 23, 2024 20:24
@hrshdhgd
Copy link
Collaborator Author

Thank you!!!

@hrshdhgd hrshdhgd removed the request for review from matentzn July 23, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sierra-moxon sierra-moxon sierra-moxon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hrshdhgd @sierra-moxon