-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add goals to generate a mapping change diff report #7962
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 important, 1 minor suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another thing I just saw
Co-authored-by: Nico Matentzoglu <[email protected]>
Co-authored-by: Nico Matentzoglu <[email protected]>
Co-authored-by: Nico Matentzoglu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, assuming you tried this!
No, actually I have not but I will. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I run sh run.sh make kgcl-diff -B
I get:
...
runoak -i simpleobo:tmp/mondo-released.obo diff -X simpleobo:mondo-base.obo -o reports/difference_release_base.yaml --output-type yaml
runoak -i simpleobo:tmp/mondo-released.obo diff -X simpleobo:mondo-base.obo \
-o reports/difference_release_base.tsv --output-type csv --statistics --group-by-property oio:hasOBONamespace
runoak -i simpleobo:tmp/mondo-released.obo diff -X simpleobo:mondo-base.obo -o reports/difference_release_base.md --output-type md
No handler for key: RemoveNodeFromSubset
When I tried: sh run.sh make all -B
I ran into this error:
MISSING FILE ERROR file '../sparql/preprocess-module.ru' does not exist
It runs in "obolibrary/odkfull:latest" and I pulled the latest.
Edit: Each make
command above resulted in failure with the error messages as posted above.
I will track that down for the sake of identifying the leak, but in general we should never run:
Always run:
Somewhere in the main pipeline there is an import dependency that should not exist anymore, but this is unrelated to this PR. |
This output was not needed for the Mondo DIFF pipeline
I ran I then checked |
@matentzn anything else that should be checked or done before merging? If nothing else is needed, can you please merge? Thank you! |
No, good to go! |
* add goals to generate a mapping change diff report * Update src/ontology/mondo.Makefile Co-authored-by: Nico Matentzoglu <[email protected]> * Update src/ontology/mondo.Makefile Co-authored-by: Nico Matentzoglu <[email protected]> * Update src/ontology/mondo.Makefile Co-authored-by: Nico Matentzoglu <[email protected]> * Remove txt KGCL output This output was not needed for the Mondo DIFF pipeline --------- Co-authored-by: Nico Matentzoglu <[email protected]>
* add goals to generate a mapping change diff report * Update src/ontology/mondo.Makefile Co-authored-by: Nico Matentzoglu <[email protected]> * Update src/ontology/mondo.Makefile Co-authored-by: Nico Matentzoglu <[email protected]> * Update src/ontology/mondo.Makefile Co-authored-by: Nico Matentzoglu <[email protected]> * Remove txt KGCL output This output was not needed for the Mondo DIFF pipeline --------- Co-authored-by: Nico Matentzoglu <[email protected]>
addresses #7230