-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE] Check features test #97 #101
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng-backend into feature/LanguageSwitcher
…ng-backend into feature/LanguageSwitcher
…controller accordingly.
…index. add new error message in ca directory.
Important change:
|
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
CollaboratorTest
andFaqsTest
due to my inability to solve the issues.FaqResource
to better pass data to json response.AppController
modified to suit the translatable functionality.Exception\Handler
modifed to return suitable error (from 500 to 422).AppTest
modified to work with translatable functionality.SendEmailTest
to exclude from massive testing. Runphp artisan test --exclude-group SendEmailTest
.AuthController
modified to follow PER specifications.UserController
to nullable and corrected the validated data when creating a new User.UserController::forgetPassword
method.LoginTest
.ResetPasswordTest
.These are the most important changes I consider should be known.
Right now the following test still fail:
CollaboratorTest
-> index get collaborators landing:
Error: Expected response status code [200] but received 500.
-> index get collaborators wiki:
Error: Expected response status code [200] but received 204.
-> index get collaborators challenges:
Error: Expected response status code [200] but received 500.
-> collaborators logic:
Error: Failed that JsonResponse Object is of type array.
-> collaborator landing function:
Error: array_merge(): Argument must be of type array, Illuminate\Http\JsonResponse given.
-> collaborator wiki function:
Error: Failed that JsonResponse Object is of type array.
-> collaborator challenges function:
Error: array_merge(): Argument must be of type array, Illuminate\Http\JsonResponse given.
FaqsTest
-> store:
Error: unable to fins Json structure within response JSON.
-> store with missing fields:
Error: Failed to find a validation error in the response for key: 'ca.description'.
-> store with long title:
Error: Failed to find a validation error in the response for key: 'title'
-> update:
Error: unable to fins Json structure within response JSON.
-> update with long title:
Error: Expected response status code [422] but received 200.