Fix joins for RedundancyGroup model
#1069
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukhwinder33445
force-pushed
the
dependencies-summary
branch
from
ab39f4f
to
72cce02
Compare
raviks789
force-pushed
the
root-problem-list
branch
5 times, most recently
from
4ae3f47
to
9506986
Compare
sukhwinder33445
force-pushed
the
dependencies-summary
branch
7 times, most recently
from
a327201
to
70e3aab
Compare
raviks789
force-pushed
the
root-problem-list
branch
from
de318ec
to
af32a03
Compare
sukhwinder33445
changed the title
DependencyNodeSummary modelRedundancyGroup model
RedundancyGroup -> DependencyEdge DependencyEdge -> DependencyNode The DependecyNodeSummary requires left joins to summarise all available rows, while the redundancy group joins DependencyEdge and DependencyNode as inner joins, which leads to false positives.
sukhwinder33445
force-pushed
the
dependencies-summary
branch
from
70e3aab
to
a35df54
Compare
sukhwinder33445
changed the base branch from
root-problem-list
to
dependencies
sukhwinder33445
changed the base branch from
dependencies
to
root-problem-list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.