-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pdm constr init deinit #185
Conversation
Signed-off-by: NikhitaR-IFX <[email protected]>
Signed-off-by: NikhitaR-IFX <[email protected]>
Signed-off-by: NikhitaR-IFX <[email protected]>
Signed-off-by: NikhitaR-IFX <[email protected]>
Signed-off-by: NikhitaR-IFX <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good progress already. Clean and neat 😺
A few things we can rework before merging. Others, maybe postpone 👍
Signed-off-by: NikhitaR-IFX <[email protected]>
Code size report:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, let´s try to solve the freq changes introduced error in the PR, after our discussions.
Signed-off-by: NikhitaR-IFX <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice !
I will merge the branch now. @ramya-subramanyam you can also check the changes in machine-pdm branch. |
Summary
There will be additional changes as I implement the read function. But so far, only initialization related parts are added. I am trying to follow the extmod/i2s way of doing this and open to suggestions if you feel the need to do any other way.
Testing