Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pdm constr init deinit #185

Merged
merged 7 commits into from
Sep 13, 2024
Merged

Pdm constr init deinit #185

merged 7 commits into from
Sep 13, 2024

Conversation

NikhitaR-IFX
Copy link
Member

Summary

  • Enabled machine.PDM_PCM module with:
  1. Constructor
  2. init
  3. deinit

There will be additional changes as I implement the read function. But so far, only initialization related parts are added. I am trying to follow the extmod/i2s way of doing this and open to suggestions if you feel the need to do any other way.

  • Added tests for enabled functions.
  • Added respective documentation.

Testing

  • The HIL test might be failing for I2S but this is only because a change needed in .exp as clock is changed from different value now. I will fix that.
  • @jaenrig-ifx : At times network_config.py test is as well failing in this branch but I have not changed anything there. Would it be possible for you to check once on your side?

Copy link
Member

@jaenrig-ifx jaenrig-ifx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress already. Clean and neat 😺
A few things we can rework before merging. Others, maybe postpone 👍

tests/ports/psoc6/board_only_hw/single/pdm_pcm.py.exp Outdated Show resolved Hide resolved
tests/ports/psoc6/board_only_hw/single/pdm_pcm.py Outdated Show resolved Hide resolved
tests/ports/psoc6/board_only_hw/single/pdm_pcm.py Outdated Show resolved Hide resolved
docs/psoc6/quickref.rst Outdated Show resolved Hide resolved
docs/psoc6/quickref.rst Outdated Show resolved Hide resolved
ports/psoc6/machine_pdm_pcm.c Show resolved Hide resolved
tests/ports/psoc6/run_psoc6_tests.sh Outdated Show resolved Hide resolved
ports/psoc6/machine_pdm_pcm.c Outdated Show resolved Hide resolved
ports/psoc6/machine_pdm_pcm.c Outdated Show resolved Hide resolved
ports/psoc6/machine_pdm_pcm.c Outdated Show resolved Hide resolved
Copy link

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:   +48 +0.012% PYBV10
     mimxrt:   +44 +0.012% TEENSY40
        rp2:   +48 +0.005% RPI_PICO_W
       samd:   +48 +0.018% ADAFRUIT_ITSYBITSY_M4_EXPRESS

Copy link
Member

@jaenrig-ifx jaenrig-ifx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, let´s try to solve the freq changes introduced error in the PR, after our discussions.

Copy link

@IFX-Anusha IFX-Anusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@NikhitaR-IFX
Copy link
Member Author

I will merge the branch now. @ramya-subramanyam you can also check the changes in machine-pdm branch.

@NikhitaR-IFX NikhitaR-IFX merged commit b1f490e into machine-pdm Sep 13, 2024
34 checks passed
@NikhitaR-IFX NikhitaR-IFX deleted the pdm-constr-init-deinit branch September 13, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants