-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draw offers #39
Draw offers #39
Conversation
Currently it only changes the dev version of the site. (Someone needs to minify it or some automated system should) |
Also users can currently spam draw offers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍! I don't know the project completely, so I just try stuff to see what sticks.
Spam prevention currently doesn't work because I forgot to update drawOfferMove in the client and the server after the checks |
Ok! I will start work on this tomorrow. Starting with the limit and local game darkening. |
It's fixed 🙂
Because I'm lazy (and don't have much time), I decided that players shouldn't be able to make moves, while there is a draw offer. I made the background less dark though. |
Refreshing the page no longer breaks it (untested), games with <2 moves cant offer draws, the draw offer UI is less dark and can't offer draws after game end. From what I've tested, it works great! Addresses Naviary's list of changes. Co-Authored-By: Naviary <[email protected]>
That's what I mean about being less intrusive, I can only imagine how annoyed people will get if they can essentially pause their opponents game. I'm thinking no black transparent backdrop, and a popup box either in the lower middle or the corner of the screen that does not interrupt your play. Don't worry if you don't have time now, take your time. I'd rather this be polished than rushed. |
Ok |
Now resembles more the official UI
It's broken (but we can always revert)
…e/infinitechess.org into pr/this-is-not-available/39
Not perfect, but it is a start