Fix/sync dev with v151 #325
Conversation
…d_secure_insecure_channels feat/refactor_network_mixed_secure_insecure_channels
…ges in the latest protobuf library version
…xes for macos runners
fix/update_protobuf_version
…into fix/sync_dev_with_v151
WalkthroughThe update primarily adjusts compatibility with a new version of the Changes
Recent Review DetailsConfiguration used: .coderabbit.yaml Files selected for processing (1)
Additional Context UsedRuff (7)
Additional comments not posted (20)
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Out of diff range and nitpick comments (1)
pyinjective/denoms_mainnet.ini (1)
754-755: Ensure consistency in decimal places for tick sizes across similar trading pairs.While the changes are correct, maintaining consistency in the decimal places used for tick sizes across similar trading pairs can improve readability and reduce potential confusion.
| ## [1.5.1] - 2024-05-02 | ||
| ### Changed | ||
| - Updated calls to `json_format.MessageToDict` for compliance with the new version of the `protobuf` library | ||
|
|
There was a problem hiding this comment.
Ensure consistency in formatting and spacing in the changelog entries.
## [1.5.1] - 2024-05-02
### Changed
- Updated calls to `json_format.MessageToDict` for compliance with the new version of the `protobuf` library
+## [1.5.1] - 2024-05-02
+### Changed
+- Updated calls to `json_format.MessageToDict` for compliance with the new version of the `protobuf` libraryCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| ## [1.5.1] - 2024-05-02 | |
| ### Changed | |
| - Updated calls to `json_format.MessageToDict` for compliance with the new version of the `protobuf` library | |
| ## [1.5.1] - 2024-05-02 | |
| ### Changed | |
| - Updated calls to `json_format.MessageToDict` for compliance with the new version of the `protobuf` library |
| [0x25b545439f8e072856270d4b5ca94764521c4111dd9a2bbb5fbc96d2ab280f13] | ||
| description = 'Mainnet Spot PYTH/INJ' | ||
| base = 6 | ||
| quote = 18 | ||
| min_price_tick_size = 10000000 | ||
| min_display_price_tick_size = 0.00001 | ||
| min_quantity_tick_size = 100000 | ||
| min_display_quantity_tick_size = 0.1 |
There was a problem hiding this comment.
Duplicate entry for 'Mainnet Spot PYTH/INJ'.
- [0x25b545439f8e072856270d4b5ca94764521c4111dd9a2bbb5fbc96d2ab280f13]
- description = 'Mainnet Spot PYTH/INJ'
- base = 6
- quote = 18
- min_price_tick_size = 10000000
- min_display_price_tick_size = 0.00001
- min_quantity_tick_size = 100000
- min_display_quantity_tick_size = 0.1This entry appears to be a duplicate of another entry for 'Mainnet Spot PYTH/INJ' with the same parameters. Please verify if this duplication is intentional or an error.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| [0x25b545439f8e072856270d4b5ca94764521c4111dd9a2bbb5fbc96d2ab280f13] | |
| description = 'Mainnet Spot PYTH/INJ' | |
| base = 6 | |
| quote = 18 | |
| min_price_tick_size = 10000000 | |
| min_display_price_tick_size = 0.00001 | |
| min_quantity_tick_size = 100000 | |
| min_display_quantity_tick_size = 0.1 |
| [0xdc44a6e8292dd72d05a1a145aa17501dd4d3543ab74a97fa163a758a71fc6d08] | ||
| description = 'Devnet Derivative rRdTb/USDT PERP' | ||
| base = 0 | ||
| quote = 6 | ||
| min_price_tick_size = 1000 | ||
| min_display_price_tick_size = 0.001 | ||
| min_quantity_tick_size = 0.01 | ||
| min_display_quantity_tick_size = 0.01 | ||
|
|
There was a problem hiding this comment.
Tip
Codebase Verification
The settings for 'Devnet Derivative rRdTb/USDT PERP' have been compared with other similar derivative products in the denoms_devnet.ini file. The comparison reveals that the settings for 'Devnet Derivative rRdTb/USDT PERP' are largely consistent with several other derivatives, particularly in terms of base, quote, min_price_tick_size, and min_display_price_tick_size.
However, there is a notable variation in the min_quantity_tick_size and min_display_quantity_tick_size settings between 'Devnet Derivative rRdTb/USDT PERP' and most other derivatives. The 'rRdTb/USDT PERP' derivative has these settings at 0.01, whereas the majority of other derivatives have these settings at 0.001. This discrepancy might be intentional based on specific requirements for the 'rRdTb/USDT PERP' derivative, but it does stand out when compared to the settings of other derivatives.
Recommendations:
- If the difference in
min_quantity_tick_sizeandmin_display_quantity_tick_sizeis intentional and justified by business or technical requirements, it may remain as is. - If consistency across derivatives is a priority, consider adjusting these settings to align with the majority of other derivatives in the configuration file.
Analysis chain
Confirm that the settings for 'Devnet Derivative rRdTb/USDT PERP' are consistent with similar derivative products.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Ensure consistency of settings for 'Devnet Derivative rRdTb/USDT PERP' with similar derivative products.
# Compare settings with other derivatives to ensure consistency.
gh issue list --search "rRdTb/USDT PERP settings comparison in denoms_devnet.ini"
Length of output: 83
Script:
#!/bin/bash
# Description: Extract settings of derivatives similar to 'Devnet Derivative rRdTb/USDT PERP' from the configuration file and compare them.
# Find the section for 'Devnet Derivative rRdTb/USDT PERP' and similar derivatives in the configuration file
grep -A 7 -B 2 "Devnet Derivative rRdTb/USDT PERP" pyinjective/denoms_devnet.ini
grep -A 7 -B 2 "PERP" pyinjective/denoms_devnet.ini | grep -v "Devnet Derivative rRdTb/USDT PERP"
Length of output: 11254
…fields_with_no_presence in json_format.MessageToDict
devbranch with changes from the latest release (v1.5.1)Summary by CodeRabbit
Refactor
protobuflibrary across various components.New Features
DevnetandMainnetenvironments.Documentation
aiohttpand relaxed constraints forurllib3.Tests