Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/sync dev with v151 #325

Merged
merged 6 commits into from
May 3, 2024
Merged

Fix/sync dev with v151 #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b43fc0a
Merge pull request #319 from InjectiveLabs/feat/refactor_network_mixe…
aarmoa Apr 19, 2024
7820edf
(fix) Updated calls to json_format.MessageToDict to adapt to the chan…
May 2, 2024
481b846
(fix) Updated run-tests.yml workflow configuration file to include fi…
May 2, 2024
433303c
Merge pull request #324 from InjectiveLabs/fix/update_protobuf_version
aarmoa May 2, 2024
d921dca
Merge branch 'master' of https://github.com/InjectiveLabs/sdk-python …
May 2, 2024
ad3f2f6
(fix) Fixed remaining usage of the deprecated parameter always_print_…
May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ All notable changes to this project will be documented in this file.
### Changed
- Refactored cookies management logic to use all gRPC calls' responses to update the current cookies

## [1.5.1] - 2024-05-02
### Changed
- Updated calls to `json_format.MessageToDict` for compliance with the new version of the `protobuf` library

Comment on lines +16 to +19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure consistency in formatting and spacing in the changelog entries.

## [1.5.1] - 2024-05-02
### Changed
- Updated calls to `json_format.MessageToDict` for compliance with the new version of the `protobuf` library
+## [1.5.1] - 2024-05-02
+### Changed
+- Updated calls to `json_format.MessageToDict` for compliance with the new version of the `protobuf` library
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
## [1.5.1] - 2024-05-02
### Changed
- Updated calls to `json_format.MessageToDict` for compliance with the new version of the `protobuf` library
## [1.5.1] - 2024-05-02
### Changed
- Updated calls to `json_format.MessageToDict` for compliance with the new version of the `protobuf` library

## [1.5.0] - 2024-04-19
### Changed
- Refactoring in Network class to support mixed secure and insecure endpoints.
Expand Down
473 changes: 222 additions & 251 deletions poetry.lock
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions pyinjective/composer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2253,7 +2253,7 @@ def MsgResponses(response, simulation=False):
@staticmethod
def UnpackMsgExecResponse(msg_type, data):
responses = []
dict_message = json_format.MessageToDict(message=data, including_default_value_fields=True)
dict_message = json_format.MessageToDict(message=data, always_print_fields_with_no_presence=True)
json_responses = Composer.unpack_msg_exec_response(underlying_msg_type=msg_type, msg_exec_response=dict_message)
for json_response in json_responses:
response = REQUEST_TO_RESPONSE_TYPE_MAP[msg_type]()
Expand All @@ -2268,7 +2268,7 @@ def unpack_msg_exec_response(underlying_msg_type: str, msg_exec_response: Dict[s
responses = [
json_format.MessageToDict(
message=REQUEST_TO_RESPONSE_TYPE_MAP[underlying_msg_type].FromString(result),
including_default_value_fields=True,
always_print_fields_with_no_presence=True,
)
for result in grpc_response.results
]
Expand Down Expand Up @@ -2298,7 +2298,7 @@ def unpack_transaction_messages(transaction_data: Dict[str, Any]) -> List[Dict[s
msgs.append(
{
"type": msg["type"],
"value": json_format.MessageToDict(message=grpc_message, including_default_value_fields=True),
"value": json_format.MessageToDict(message=grpc_message, always_print_fields_with_no_presence=True),
}
)

Expand Down
283 changes: 283 additions & 0 deletions pyinjective/denoms_devnet.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,15 @@ min_display_price_tick_size = 0.000001
min_quantity_tick_size = 1000000
min_display_quantity_tick_size = 1

[0xd166688623206f9931307285678e9ff17cecd80a27d7b781dd88cecfba3b1839]
description = 'Devnet Spot BLACK/INJ'
base = 6
quote = 18
min_price_tick_size = 1000000
min_display_price_tick_size = 0.000001
min_quantity_tick_size = 1000000
min_display_quantity_tick_size = 1

[0x1422a13427d5eabd4d8de7907c8340f7e58cb15553a9fd4ad5c90406561886f9]
description = 'Devnet Derivative COMP/USDT PERP'
base = 0
Expand Down Expand Up @@ -286,6 +295,276 @@ min_display_price_tick_size = 0.0000000001
min_quantity_tick_size = 0.1
min_display_quantity_tick_size = 0.1

[0x7f2a8e1253006061b5c21c7491d980896d4a2f585c9467d9403884ef74783294]
description = 'Devnet Derivative Yvcek/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 1000
min_display_price_tick_size = 0.001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

[0xdc44a6e8292dd72d05a1a145aa17501dd4d3543ab74a97fa163a758a71fc6d08]
description = 'Devnet Derivative rRdTb/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 1000
min_display_price_tick_size = 0.001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

Comment on lines +307 to +315
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

Codebase Verification

The settings for 'Devnet Derivative rRdTb/USDT PERP' have been compared with other similar derivative products in the denoms_devnet.ini file. The comparison reveals that the settings for 'Devnet Derivative rRdTb/USDT PERP' are largely consistent with several other derivatives, particularly in terms of base, quote, min_price_tick_size, and min_display_price_tick_size.

However, there is a notable variation in the min_quantity_tick_size and min_display_quantity_tick_size settings between 'Devnet Derivative rRdTb/USDT PERP' and most other derivatives. The 'rRdTb/USDT PERP' derivative has these settings at 0.01, whereas the majority of other derivatives have these settings at 0.001. This discrepancy might be intentional based on specific requirements for the 'rRdTb/USDT PERP' derivative, but it does stand out when compared to the settings of other derivatives.

Recommendations:

  • If the difference in min_quantity_tick_size and min_display_quantity_tick_size is intentional and justified by business or technical requirements, it may remain as is.
  • If consistency across derivatives is a priority, consider adjusting these settings to align with the majority of other derivatives in the configuration file.
Analysis chain

Confirm that the settings for 'Devnet Derivative rRdTb/USDT PERP' are consistent with similar derivative products.

Scripts Executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Ensure consistency of settings for 'Devnet Derivative rRdTb/USDT PERP' with similar derivative products.

# Compare settings with other derivatives to ensure consistency.
gh issue list --search "rRdTb/USDT PERP settings comparison in denoms_devnet.ini"

Length of output: 83

Script:

#!/bin/bash
# Description: Extract settings of derivatives similar to 'Devnet Derivative rRdTb/USDT PERP' from the configuration file and compare them.

# Find the section for 'Devnet Derivative rRdTb/USDT PERP' and similar derivatives in the configuration file
grep -A 7 -B 2 "Devnet Derivative rRdTb/USDT PERP" pyinjective/denoms_devnet.ini
grep -A 7 -B 2 "PERP" pyinjective/denoms_devnet.ini | grep -v "Devnet Derivative rRdTb/USDT PERP"

Length of output: 11254

[0x4815c00dc47b5dc7ec6b9f39bbb470dc0480e05909b34556232da961eaf6706f]
description = 'Devnet Derivative PMSJi/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 1000
min_display_price_tick_size = 0.001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

[0xa9e0d8b1ccd91645522e69dd22dd3886c7799ad28d89483a23d15f24785f1cbf]
description = 'Devnet Derivative aHUBZ/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 1000
min_display_price_tick_size = 0.001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

[0xef6d48cd7730e9ae0b5d7a5cda91ab8c9b6958925241db0de312a9b5b8ca6174]
description = 'Devnet Derivative JMNHn/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 1000
min_display_price_tick_size = 0.001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

[0x16a18bd31c16f3d4eccf8ec735af7787f22ebe9527124315550b1597873e0bc3]
description = 'Devnet Derivative LmurW/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 1000
min_display_price_tick_size = 0.001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

[0x3b07c2a88a906c433b3ba202315a73c1d3658c1782efddceaf021c03a11220a9]
description = 'Devnet Derivative OUdeG/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 1000
min_display_price_tick_size = 0.001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

[0x66072f526a9bbd51e43d095b9847f8ec3de2169acbc941d2a0d0b0f8b47de14e]
description = 'Devnet Derivative KStzF/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 1
min_display_price_tick_size = 0.000001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

[0x290ea838b02d47902fc95392de3a387ae0bc0001130560c350a5b3cbf8d944e6]
description = 'Devnet Derivative TCXRu/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 1
min_display_price_tick_size = 0.000001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

[0x899fe3b0dbedea9229be2c2711f4fbe3f8aec3fd65678567db771c661cda16b8]
description = 'Devnet Derivative DqnMP/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 1
min_display_price_tick_size = 0.000001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

[0x27f58926f9413414b855d9895f8f389bfa029116f933e0f19e97be4dd3d0877e]
description = 'Devnet Derivative ceLAy/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 1
min_display_price_tick_size = 0.000001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

[0x574c0ce69f5be41036aa2503d7f20862fae35a7f9f417684fe2983aafa4ac04b]
description = 'Devnet Derivative vmoUr/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 1
min_display_price_tick_size = 0.000001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

[0x40e7ffe2caaab13fb5cf59f8f662237d3b166b46e5f0b284b012e7872ea534ce]
description = 'Devnet Derivative sltjp/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 1
min_display_price_tick_size = 0.000001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

[0xf10b867312254f18abc8d21bf15f6acdd7a5200fd8688837528d259702b9b2d8]
description = 'Devnet Derivative kMoLd/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 1
min_display_price_tick_size = 0.000001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

[0x6caa9a43eb25794d1664a89731b51c177f3ab642b9bd4a5c4170d01bec5cfee5]
description = 'Devnet Derivative INllC/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 1
min_display_price_tick_size = 0.000001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

[0x4d041bf90b285a1de037faa354f8d0697dc18512381ad3a782faa158c8df0282]
description = 'Devnet Derivative jwPvq/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 1
min_display_price_tick_size = 0.000001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

[0x367f418ec1f796a19bef6ff9dc1b70fedb46238bbb7c952bd37efd22b937a10e]
description = 'Devnet Derivative FWQWO/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 1
min_display_price_tick_size = 0.000001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

[0x75c7b4beabf3db173b82a916c98377416ba2779f815976c69424345b041e357e]
description = 'Devnet Derivative JCKqR/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 1
min_display_price_tick_size = 0.000001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

[0x3dda0eb99f27083fe07b44837adbe4cecbadcd8e881994f044de2f464894e9b8]
description = 'Devnet Derivative UBHiV/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 1
min_display_price_tick_size = 0.000001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

[0x8da64a935e7b9b1fbb3a9b50c570b361ca0583293a4e97dfe14d7b57b94f5f1d]
description = 'Devnet Derivative NcgYC/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 1
min_display_price_tick_size = 0.000001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

[0xdb6536e47062df2a3a565c47016c6dc19c5207c31e2e2b4f346967e126fd2204]
description = 'Devnet Derivative cntQK/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 1
min_display_price_tick_size = 0.000001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

[0xf9f0ec6cdd07b773ce69ba9b79ca8139b51a15a41fe7d4a6f4f819007eb68208]
description = 'Devnet Derivative SONAJ/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 0.01
min_display_price_tick_size = 0.00000001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

[0x645757ab9ecdea6e438f5bd0c5b2617ad7c437d3fabb91207a8b13f4e36a8236]
description = 'Devnet Derivative NSNME/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 0.01
min_display_price_tick_size = 0.00000001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

[0x1bbefa3a17c98836c00be107e16bb370367fbfde4ca764be7d464223e2947ee6]
description = 'Devnet Derivative pQqmD/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 0.01
min_display_price_tick_size = 0.00000001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

[0xca6d0fae5e3ba5ef964af03f22b3585cc00dab447d1a091cb229312c7c6dbf21]
description = 'Devnet Derivative dEhsM/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 0.01
min_display_price_tick_size = 0.00000001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

[0xe4813e500717dbbe689c219ad0c91f7471b06c8a5f1c03a8e7fa8c1c095c530d]
description = 'Devnet Derivative FgXEY/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 0.01
min_display_price_tick_size = 0.00000001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

[0xf77923be4d1910297893872f937efcec9aef9fd3b72c29d258c783575576d670]
description = 'Devnet Derivative YgYbX/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 0.01
min_display_price_tick_size = 0.00000001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

[0x87562628ec23650498e74dd0cff9cec4e68728f7a6cd4c5206e1511fbf3a203f]
description = 'Devnet Derivative TENMX/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 0.01
min_display_price_tick_size = 0.00000001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

[0x8be690d528567804337633d80f1f0b3b3f5ecf4314aaf54919794c984b03cee6]
description = 'Devnet Derivative gLNiU/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 0.01
min_display_price_tick_size = 0.00000001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

[0x72c6445f01e11cd687e26f27fb0a5a01d66bd08e6f1421618013d5802d08a499]
description = 'Devnet Derivative XcdUO/USDT PERP'
base = 0
quote = 6
min_price_tick_size = 0.01
min_display_price_tick_size = 0.00000001
min_quantity_tick_size = 0.01
min_display_quantity_tick_size = 0.01

[AAVE]
peggy_denom = peggy0x7Fc66500c84A76Ad7e9c93437bFc5Ac33E2DDaE9
decimals = 18
Expand All @@ -298,6 +577,10 @@ decimals = 18
peggy_denom = ibc/C4CFF46FD6DE35CA4CF4CE031E643C8FDC9BA4B99AE598E9B0ED98FE3A2319F9
decimals = 6

[BLACK]
peggy_denom = factory/inj16eckaf75gcu9uxdglyvmh63k9t0l7chd0qmu85/black
decimals = 6

[BNB]
peggy_denom = peggy0xB8c77482e45F1F44dE1745F52C74426C631bDD52
decimals = 18
Expand Down
Loading
Loading