Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ROS 2 puppet demo launch #179

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Fix ROS 2 puppet demo launch #179

merged 2 commits into from
Apr 10, 2024

Conversation

lukeschmitt-tr
Copy link
Member

Related to https://github.com/orgs/Interbotix/discussions/48

This PR does the following:

  • Fixes a launch file scope issue where motor configs would not be passed down to the xsarm_control launch includes.

Credit to @kandeng for discovering the issue and to @swiz23 for the fix.

@lukeschmitt-tr lukeschmitt-tr added the bug Something isn't working label Apr 9, 2024
@swiz23
Copy link
Contributor

swiz23 commented Apr 10, 2024

lgtm

@kandeng
Copy link

kandeng commented Apr 10, 2024

Awesome !

@lukeschmitt-tr lukeschmitt-tr merged commit 552368e into humble Apr 10, 2024
1 check passed
@lukeschmitt-tr lukeschmitt-tr deleted the fix_puppet_demo_launch branch April 10, 2024 21:30
lukeschmitt-tr added a commit that referenced this pull request Apr 10, 2024
* Fix xsarm_puppet demo launch

* Allow motor configs to be passed as launch arg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants