Cleanup character io interfaces #348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Committing this branch for further testing. I know at least that the TTY output stream somehow is defaulting to :XCCS, which is wrong, but I haven't yet found the interface for that.
No top-level calls to the NS specific functions, just to the generic \OUTCHAR etc. Updated full.database
They can be dragged by their title bars
Also made spelling of default-externalformats consistent with FILEIO
EOL's printed as LF's will be read as EOL
meta,a maps to 1,a now. But slowly propagating this to TEDIT, SEDIT, etc will make it easier to change the coding of meta characters, e.g. as part of a Unicode transition.
Removed the macro
Minor cleanup, avoid typical user entry and APPLY*
Also sets up mappings in the \COMMANDKEYACTIONS, whatever that is
So that things like Masterscope don't break
Looks at the WHEREIS database, if present, for FNS and FUNCTIONS if it has no other information. . WHO CONTAINS ANY CALLING FOO works, but not the inverse: . WHO DOES FUM CONTAIN. We still need to figure out why the CONTAINS table isn't populated
Now uses generic \OUTCHAR to get the proper function from the stream (or default)
Some of the macros weren't correct.
Cleaner separation between external \OUTCHAR and internal BOUT
#343 \TEDIT.BUTTONEVENTFN actually takes a second STREAM argument. I don't see where it is ever called with that. The modernize replacement binds that argument, but it isn't being passed to the original.
Mostly just qualifying references, more work to get BIGBITMAP stuff out of ADISPLAY and to eliminate ambiguity of LINE record (now XXLINE in XXGEOM)
Mostly new LCOMS where \OUTCHAR calls were compiled open
Old tools for reading wikipedia XCCS tables, sources/XCCS will deal with XCCS external format
… file XCCS is the default, but can be swapped out (eventually) by setting a few variables, without recompiling everything
masinter
reviewed
Jul 22, 2021
masinter
reviewed
Jul 22, 2021
There was a problem hiding this comment.
CHAT was recompiled with no changes. CHAT(SHELL) is the only useful CHAT target.
But shouldn't it assume :UTF-8 ? I think CHAT(host) could turn into ssh but for now it is better to leave out?
CHAT(SHELL) currently always opens /bin/csh (C-shell) which isn't in most Linux distros. See #121
|
I think this was something else that got included to make the masterscope analysis more accurate, making sure that all ambiguous field names were qualified.
… On Jul 22, 2021, at 9:12 AM, Larry Masinter ***@***.***> wrote:
@masinter commented on this pull request.
there were changes (introductions of functions) to BIGBITMAPS in the library -- not loaded in FULL. Were these not part of the IO functions?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#348 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJORUI5BFR2E7AL7H73TZA7NVANCNFSM47OWLHAA>.
|
|
Could be that macros or records changed underneath.
… On Jul 22, 2021, at 9:34 AM, Ron Kaplan ***@***.***> wrote:
I think this was something else that got included to make the masterscope analysis more accurate, making sure that all ambiguous field names were qualified.
> On Jul 22, 2021, at 9:12 AM, Larry Masinter ***@***.*** ***@***.***>> wrote:
>
>
> @masinter commented on this pull request.
>
> there were changes (introductions of functions) to BIGBITMAPS in the library -- not loaded in FULL. Were these not part of the IO functions?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub <#348 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJORUI5BFR2E7AL7H73TZA7NVANCNFSM47OWLHAA>.
>
|
|
Dunno
… On Jul 22, 2021, at 8:54 AM, Larry Masinter ***@***.***> wrote:
@masinter commented on this pull request.
why is sources/LLREAD.LCOM.1 on .gitignore? it already ignores *~
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#348 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJJHMGXMKTGPEMRJLXLTZA5MPANCNFSM47OWLHAA>.
|
masinter
reviewed
Jul 22, 2021
There was a problem hiding this comment.
there was a change to SYSEDIT that removed resetting MSMACROPROPS to leave MACRO-FN on the list, leaving the value on MSANALYZE. Macros for all kinds are analyzed by analyzing their expansion. There was also a patch to remove / no longer generate spurious incorrect masterscope "templates" (call to SETTEMPLATE in GETTEMPLATE).
Otherwise,
masinter
reviewed
Jul 22, 2021
masinter
reviewed
Jul 22, 2021
masinter
reviewed
Jul 22, 2021
masinter
reviewed
Jul 22, 2021
masinter
reviewed
Jul 22, 2021
|
Is this a change that didn’t get captured in this branch? I don’t remember doing anything about macroprops or templates.
I did fix masterscope to go to the whereis database as a last resort for CONTAINS queries, so I could find the things I needed to work on.
(Also, I extended DUMPDATABASE to take a FILE argument so that it could dump the database with a define-file-info reader environment that would load in all contexts.)
… On Jul 22, 2021, at 12:28 PM, Larry Masinter ***@***.***> wrote:
@masinter commented on this pull request.
there was a change to SYSEDIT that removed resetting MSMACROPROPS to leave MACRO-FN on the list, leaving the value on MSANALYZE. Macros for all kinds are analyzed by analyzing their expansion. There was also a patch to remove / no longer generate spurious incorrect masterscope "templates" (call to SETTEMPLATE in GETTEMPLATE).
Otherwise,
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#348 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJKHYE3WRK3XAWX6BOTTZBWMJANCNFSM47OWLHAA>.
|
|
Yes, to export a test that didn’t require the declaration to be present. (The logic in that code is still a little confusing, I think the bigbitmap extension is wired in at a slightly wrong level. But I left it.)
… On Jul 22, 2021, at 1:11 PM, Larry Masinter ***@***.***> wrote:
@masinter commented on this pull request.
In library/BIGBITMAPS <#348 (comment)>:
> @@ -84,6 +88,10 @@
'6)
(DEFINEQ
+(BIGBITMAPP
I suppose these changes are to avoid the cross-file record access. Sorry that just became clear.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#348 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJIA23UR437NKX3CJCLTZB3PTANCNFSM47OWLHAA>.
|
masinter
requested changes
Jul 23, 2021
There was a problem hiding this comment.
The problem with MSMACROPROPS is just an indication that you made your branch and didn't update it from master for months; I wasn't doing a lot of editing but we need to resolve the conflicts (not many).
I've gone through about 50 / 150 of the changed files in about 5 hours. I'll try to go through the rest.
| @@ -1454,42 +1570,42 @@ | |||
| DESWRD)) | |||
| WIDTH MAP 0COLOR 1COLOR)) | |||
| (COND | |||
There was a problem hiding this comment.
is there a reason the font-change character changed in a way that makes these changes show up in diffs
|
Thanks for slogging through this, I know it’s a lot.
In terms of legacy dates, I thought it was set up to do that. It certainly does that in my LFG environment. Maybe there is a flag some where that should be set.
In fact, it seems that in LFG I have a file EDITDATEPATCH that has a variable SINGLEEDITDATE that controls that. Maybe the system edit date isn’t set up that way.
… On Jul 22, 2021, at 8:50 PM, Larry Masinter ***@***.***> wrote:
@masinter requested changes on this pull request.
The problem with MSMACROPROPS is just an indication that you made your branch and didn't update it from master for months; I wasn't doing a lot of editing but we need to resolve the conflicts (not many).
I've gone through about 50 / 150 of the changed files in about 5 hours. I'll try to go through the rest.
In library/BIGBITMAPS <#348 (comment)>:
> @@ -1400,14 +1516,14 @@
(RETURN COLORBITMAP))))
(\\BWTOCOLORBLT
- (LAMBDA (SOURCEBWBM SLEFT SBOTTOM DESTCOLORBM DLEFT DBOTTOM WIDTH HEIGHT 0COLOR 1COLOR DESTNBITS)
- (* \; "Edited 13-Jul-90 14:11 by matsuda")
-
- (* |blits| |from| \a |black| |and| |white| |bitmap| |into| \a |color| |bitmap|
- |which| |has| DESTNBITS |bits| |per| |pixel.|
- DESTCOLORBM |is| \a |pointer| |to| |the| |color| |bitmap.|)
- (* |assumes| |all| |datatypes| |and|
- |bounds| |have| |been| |checked|)
+ (LAMBDA (SOURCEBWBM SLEFT SBOTTOM DESTCOLORBM DLEFT DBOTTOM WIDTH HEIGHT 0COLOR 1COLOR DESTNBITS)
+ (* \; "Edited 8-May-2021 22:31 by rmk:")
shouldn't we leave in the "legacy" edit dates?
In library/BIGBITMAPS <#348 (comment)>:
> @@ -1454,42 +1570,42 @@
DESWRD))
WIDTH MAP 0COLOR 1COLOR))
(COND
is there a reason the font-change character changed in a way that makes these changes show up in diffs
In library/BIGBITMAPS <#348 (comment)>:
> (BITBLT DESTCOLORBM DESALIGNLEFT DBOTTOM DESTCOLORBM (IPLUS
DESALIGNLEFT
DESOFF)
DBOTTOM WIDTH HEIGHT 'INPUT 'REPLACE)
(BITBLT SCR 0 0 DESTCOLORBM DESALIGNLEFT DBOTTOM DESOFF HEIGHT
'INPUT
'REPLACE)))))
- (8 ((OPCODES SUBRCALL 142 11)
it looks like the (OPCODES SUBRCALL ...) was moved? We should look soon at BIGBITMAP/LLCOLOR and document what we find.
In library/CLIPBOARD <#348 (comment)>:
> @@ -203,8 +203,8 @@
)
(PUTPROPS CLIPBOARD COPYRIGHT (NONE))
copyright Interlisp.org?
Paste on windows/linux into lisp seems fine but I don't see meta-C copy work.
the documentation -- such as it is -- says UNIX-GETENV("ostype") but I believe it is case sensitive UNIX-GETENV("OSTYPE") -- which is NIL on my system. This probably needs documentation in the Medley new release notes.
In library/FILEBROWSER <#348 (comment)>:
> @@ -1,12 +1,11 @@
-(DEFINE-FILE-INFO READTABLE "XCL" PACKAGE "INTERLISP")
-(FILECREATED "27-Feb-2021 20:08:26"
-|{DSK}<Users>kaplan>Local>medley3.5>git-medley>library>FILEBROWSER.;33| 261320
+(DEFINE-FILE-INFO PACKAGE "INTERLISP" READTABLE "XCL" BASE 10 FORMAT XCCS)
the bigger DEFINE-FILE-INFO ... is that necessary?
:BASE 10 ? I'm still uncomfortable with :FORMAT, and with what seems like excessive generality (it's either XCCS-runcode or UTF-8?
In library/MASTERSCOPE <#348 (comment)>:
> @@ -2649,10 +2668,10 @@ Copyright (c) 1983-1988, 1990, 1993-1994, 2018, 2020-2021 by Venue & Xerox Corpo
(DEFINEQ
(MSINTERPRETSET
- [LAMBDA (SET OP ARG) (* ; "Edited 15-Aug-90 11:50 by jds")
All files (just noticed here) legacy editdates should be retained
In library/MASTERSCOPE <#348 (comment)>:
> @@ -2759,16 +2778,17 @@ Copyright (c) 1983-1988, 1990, 1993-1994, 2018, 2020-2021 by Venue & Xerox Corpo
(SHOULDNT 12)))
(QUOTE (SELECTQ OP
(CHECK (COND
- (ARG (SETQ NEEDUPDATE (UNION NEEDUPDATE (fetch QUOTED
- of REP)))
+ (ARG (SETQ NEEDUPDATE (UNION NEEDUPDATE (fetch
+ 'QUOTED of
the ' in (fetch 'QUOTED of REP) doesn't look right -- rename the record QUOTE to Q?
In library/POSTSCRIPTSTREAM <#348 (comment)>:
>
(* ; "
-Copyright (c) 1989, 1990, 1991, 1992, 1993, 1994, 1995, 1997, 1998, 2018 by Venue This program or documentation contains confidential information and trade secrets of Venue. Reverse engineering, reverse compiling and disassembling of object code are prohibited. Use of this program or documentation is governed by written agreement with Venue. Use of copyright notice is precautionary and does not imply publication or disclosure of trade secrets. All rights reserved.
+Copyright (c) 1989-1995, 1997-1998, 2018, 2021 by Venue This program or documentation contains confidential information and trade secrets of Venue. Reverse engineering, reverse compiling and disassembling of object code are prohibited. Use of this program or documentation is governed by written agreement with Venue. Use of copyright notice is precautionary and does not imply publication or disclosure of trade secrets.
copyright 1989-1995 Venue 2018-2021 Interlisp.org
Remove "license" statement entirely
In library/POSTSCRIPTSTREAM <#348 (comment)>:
> "%%%%Title: "
(MKSTRING (OR (LISTGET OPTIONS 'DOCUMENT.NAME)
FILE))
T "%%%%Creator: PostScript Driver Copyright (C) 1988-1992 Venue and others" T
"%%%%CreationDate: " (DATE)
T %# (COND
- ((EQ 'LPT (FILENAMEFIELD FP 'HOST))
+ ((EQ 'LPT (FILENAMEFIELD STREAM 'HOST))
The break page mechanism is archaic. Creating PDF with Unicode would be better. Does {LPT} work?
In library/POSTSCRIPTSTREAM <#348 (comment)>:
> + ("356,342" SYMBOL "2,375")
+ (* ; "centerrightbracce")
+ ("356,343" SYMBOL "2,376")
+ (* ; "bottomrightbracce")
+ ("356,344" SYMBOL "2,354")
+ (* ; "topleftbracce")
+ ("356,345" SYMBOL "2,356")
+ (* ; "bottomleftbracce")
+ ("356,346" SYMBOL "2,355")
+ (* ; "centerleftbracce")
+ ("356,355" SYMBOL "2,363")
+ (* ; "integraltop")
+ ("356,356" SYMBOL "2,365")
+ (* ; "integralbottom")
+ ("356,357" SYMBOL "2,364")
+ (* ; "integralcenter")))
Any ideas what's wrong with the prettyprinter ?
In library/RDSYS <#348 (comment)>:
> @@ -1,78 +1,78 @@
-(DEFINE-FILE-INFO READTABLE "INTERLISP" PACKAGE "INTERLISP")
-(FILECREATED "29-Apr-2021 09:48:22" {DSK}<Users>kaplan>Local>medley3.5>git-medley>tmp>RDSYS.;19
+(DEFINE-FILE-INFO PACKAGE "INTERLISP" READTABLE "XCL" BASE 10 FORMAT XCCS)
it doesn't seem right for RDSYS's READTABLE to change from "INTERLISP" to "XCL". Why?
In library/TEDITHCPY <#348 (comment)>:
> + (* ;
+ "0.75 inches from bottom, 1 from top")
+ )
+ [COMS
+ (* ;; "Support for the window-menu's HARDCOPY button, LISTFILES, etc.")
+
+ (FNS TEDIT.HARDCOPYFN \TEDIT.HARDCOPY \TEDIT.PRESS.HARDCOPY)
+ (P (LISTPUT (ASSOC 'CONVERSION (ASSOC 'INTERPRESS PRINTFILETYPES))
+ 'TEDIT
+ (FUNCTION \TEDIT.HARDCOPY)))
+ (P (LET [(PRESSVALUES (ASSOC 'CONVERSION (ASSOC 'PRESS PRINTFILETYPES]
+ (COND (PRESSVALUES (* ;
+ "Only install PRESS printing if PRESS is loaded.")
+ (LISTPUT PRESSVALUES 'TEDIT (FUNCTION \TEDIT.PRESS.HARDCOPY]
+ (COMS
+ (* ;; "vars for Japanese Line Break")
an example of code assuming XCCS
In library/UNICODE <#348 (comment)>:
> @@ -19,7 +19,7 @@
(INITVARS (EXTERNALEOL 'LF))
(FNS MAKE-UNICODE-FORMATS)
(P (MAKE-UNICODE-FORMATS EXTERNALEOL))
- (ADDVARS (*DEFAULT-EXTERNAL-FORMATS* (UNIX :UTF8)))
+ (ADDVARS (*DEFAULT-EXTERNALFORMATS* (UNIX :UTF8)))
shouldn't this be UTF-8 and not UTF8?
why "UNIX"?
In library/UNICODE <#348 (comment)>:
> @@ -58,23 +58,18 @@
(GLOBALVARS *XCCSTOUNICODE* *UNICODETOXCCS*))
(FNS HEXSTRING UTF8HEXSTRING NUTF8CODEBYTES NUTF8STRINGBYTES XTOUSTRING XCCSSTRING)
(FNS SHOWCHARS)
- (DECLARE%: ***@***.*** DONTCOPY
-
- (* ;; "This is taken from FILEIO")
-
- (CONSTANTS (LF.EOLC 1)
- (CR.EOLC 0)
- (CRLF.EOLC 2))
+ (DECLARE%: ***@***.*** DONTCOPY (P (OR (GETP 'EXPORTS.ALL 'FILE)
compiling is so fast no one will watch. Files that need other files to compile should just load them.
In library/UNICODE <#348 (comment)>:
> @@ -132,201 +127,11 @@
(LOADBYTE C 0 6)))
ELSE (ERROR "CHARCODE too big for UTF8" C])
-(UTF8.INCCODEFN
I'm not sure what's responsible, but loadups take twice as long. This looks not very performant
In library/UNICODE <#348 (comment)>:
> - (SETQ CODE (UNICODE.TRANSLATE CODE *UNICODETOXCCS*)))
- (RETURN (IF COUNTP
- THEN (CL:VALUES CODE 0)
- ELSE CODE])
-
-(\UTF8.BACKCHARFN
- [LAMBDA (STREAM COUNTP) (* ; "Edited 26-Jul-2020 10:41 by rmk:")
-
- (* ;; "\BACKFILEPTR is NIL at beginning of FILE, just return COUNT")
-
- (BIND (C _ 0) WHILE (CL:WHEN (\BACKFILEPTR STREAM)
- (ADD C 1)
- (EQ 2 (LRSH (\PEEKBIN STREAM)
- 6))) REPEATUNTIL (EQ C 4)
- FINALLY (RETURN (AND COUNTP C])
+(UTF8.INCCODEFN
[LAMBDA (STREAM BYTECOUNTVAR BYTECOUNTVAL RAW) (* ; "Edited 15-Jun-2021 13:35 by rmk:")
(* ; "Edited 6-Aug-2020 17:13 by rmk:")
(* ;; "Do not do UNICODE to XCSS translation if RAW.")
(* ;; "Test for smallp because the stream's End-of-file operation may suppress the error")
(LET (BYTE1 BYTE2 BYTE3 BYTE4 CODE (COUNT 1))
(SETQ BYTE1 (\BIN STREAM))
(* ;; "Distinguish on header bytes (modulo peculiar EOF behavior--the caller will get whatever ended up in BYTE1")
(CL:WHEN (SMALLP BYTE1)
[SETQ CODE
(IF (ILESSP BYTE1 128)
THEN
(* ;;
"Test first: Ascii is the common case. EOL requires its own translation")
(SELCHARQ BYTE1
(CR (SELECTC (FETCH (STREAM EOLCONVENTION) OF STREAM)
(CR.EOLC (* ; "Also eq BYTE1")
(CHARCODE EOL))
(CRLF.EOLC (IF (EQ (CHARCODE LF)
(\PEEKBIN STREAM T))
THEN (\BIN STREAM)
(CL:WHEN BYTECOUNTVAR
(SETQ BYTECOUNTVAR (IDIFFERENCE
BYTECOUNTVAL
2)))
(CHARCODE EOL)
ELSE BYTE1))
BYTE1))
(LF (CL:IF (EQ LF.EOLC (FETCH (STREAM EOLCONVENTION) OF STREAM))
(CHARCODE EOL)
BYTE1))
BYTE1)
ELSEIF (IGEQ BYTE1 (LLSH 15 4))
THEN (* ; "4 bytes")
(SETQ BYTE2 (\BIN STREAM))
(CL:WHEN (OR (NOT (SMALLP BYTE2))
(ILESSP BYTE2 128))
(ERROR "INVALID UTF8 SEQUENCE" (LIST BYTE1 BYTE2)))
(SETQ BYTE3 (\BIN STREAM))
(CL:WHEN (OR (NOT (SMALLP BYTE3))
(ILESSP BYTE3 128))
(ERROR "INVALID UTF8 SEQUENCE" (LIST BYTE1 BYTE2 BYTE3)))
(SETQ BYTE4 (\BIN STREAM))
(CL:WHEN (OR (NOT (SMALLP BYTE4))
(ILESSP BYTE4 128))
(ERROR "INVALID UTF8 SEQUENCE" (LIST BYTE1 BYTE2 BYTE3 BYTE4)))
(SETQ COUNT 4)
(LOGOR (LLSH (LOADBYTE BYTE1 0 3)
18)
(LLSH (LOADBYTE BYTE2 0 6)
12)
(LLSH (LOADBYTE BYTE3 0 6)
6)
(LOADBYTE BYTE4 0 6))
ELSEIF (IGEQ BYTE1 (LLSH 7 5))
THEN (* ; "3 bytes")
(SETQ BYTE2 (\BIN STREAM))
(CL:WHEN (OR (NOT (SMALLP BYTE2))
(ILESSP BYTE2 128))
(ERROR "INVALID UTF8 SEQUENCE" (LIST BYTE1 BYTE2)))
(SETQ BYTE3 (\BIN STREAM))
(CL:WHEN (OR (NOT (SMALLP BYTE3))
(ILESSP BYTE3 128))
(ERROR "INVALID UTF8 SEQUENCE" (LIST BYTE1 BYTE2 BYTE3)))
(SETQ COUNT 3)
(LOGOR (LLSH (LOADBYTE BYTE1 0 4)
12)
(LLSH (LOADBYTE BYTE2 0 6)
6)
(LOADBYTE BYTE3 0 6))
ELSE (* ; "Must be 2 bytes")
(SETQ COUNT 2)
(SETQ BYTE2 (\BIN STREAM))
(CL:WHEN (OR (NOT (SMALLP BYTE2))
(ILESSP BYTE2 128))
(ERROR "INVALID UTF8 SEQUENCE" (LIST BYTE1 BYTE2)))
(LOGOR (LLSH (LOADBYTE BYTE1 0 5)
6)
(LOADBYTE BYTE2 0 6])
(CL:UNLESS (OR RAW (NOT (SMALLP CODE)))
(SETQ CODE (UNICODE.TRANSLATE CODE *UNICODETOXCCS*)))
(CL:WHEN BYTECOUNTVAR
(SET BYTECOUNTVAR (IDIFFERENCE BYTECOUNTVAL COUNT)))
CODE])
not pretty-printed can't be reviewed in github
In library/UNICODE.TXT <#348 (comment)>:
> @@ -36,9 +36,9 @@ The function STREAMPROP obtains or changes the external format of an open stream
In the latter case, the stream's format is changed to :UTF8 and the previous value is returned, in this example it is Medley's historical default format :XCCS.
UTF-8
In library/XCCS <#348 (comment)>:
> @@ -1,412 +0,0 @@
-(DEFINE-FILE-INFO READTABLE "INTERLISP" PACKAGE "INTERLISP")
-(FILECREATED " 4-Aug-2020 22:36:36" {DSK}<Users>kaplan>Local>medley3.5>lispcore>library>XCCS.;4 23636
XCCS was deleted but XCCS.LCOM is still there?
In library/lafite/LAFITE <#348 (comment)>:
> @@ -1,16 +1,21 @@
(DEFINE-FILE-INFO PACKAGE "INTERLISP" READTABLE "INTERLISP" BASE 10)
-(FILECREATED "22-Aug-94 13:00:22" {DSK}<king>export>lispcore>lafite>parc-94>LAFITE.;2 73704
not sure about Lafite in Medley being available for open source
In library/lafite/LAFITE <#348 (comment)>:
>
(* ; "
-Copyright (c) 1982, 1983, 1984, 1985, 1986, 1987, 1988, 1989, 1993, 1994 by Xerox Corporation and Bolt Beranek and Newman Inc.. All rights reserved.
+Copyright (c) 1982-1989, 1993-1994, 2021 by Xerox Corporation and Bolt Beranek and Newman Inc..
might need to move it to another repo
In lispusers/ISO8859IO <#348 (comment)>:
> - (* ;; "From FILEIO")
-
- (CONSTANTS (\NORUNCODE 255))
-
- (* ;; "From LLCHAR")
-
- (CONSTANTS (NSCHARSETSHIFT 255))
-
- (* ;; "From LLREAD")
-
- (MACROS \XCCSIN \XCCSPEEK \BACKXCCSCHAR)
-
- (* ;; "From MODARITH")
-
- (MACROS UNFOLD))))
+ (DECLARE%: ***@***.*** DONTCOPY (P (OR (GETP 'EXPORTS.ALL 'FILE)
***@***.*** (files (source) sysedit) ?
Are these all useful external formats?
In lispusers/MODERNIZE <#348 (comment)>:
>
(* ;; "Add some Meta commands")
(FNS TEDIT.MODERNIZE TEDIT.SELECTALL)
- (DECLARE%: ***@***.*** DOCOPY (P (TEDIT.MODERNIZE)
+ (DECLARE%: ***@***.*** DOCOPY (P
Does this work in a LISP.SYSOUT without TEdit loaded?
In lispusers/MODERNIZE <#348 (comment)>:
>
- (CL:UNLESS (WINDOWPROP WINDOW 'PREMODERN-BUTTONEVENTFN)
- (WINDOWPROP WINDOW 'PREMODERN-BUTTONEVENTFN (WINDOWPROP WINDOW 'BUTTONEVENTFN))
- (WINDOWPROP WINDOW 'BUTTONEVENTFN (IF ANYWHERE
- THEN (FUNCTION MODERNWINDOW.BUTTONEVENTFN.ANYWHERE)
- ELSE (FUNCTION MODERNWINDOW.BUTTONEVENTFN))))
+ (CL:WHEN (AND TITLEPROPORTION (GREATERP TITLEPROPORTION 0.5))
+ (ERROR "TITLEPROPORTION cannot be greater than .5"))
+ (CL:WHEN (WINDOWPROP WINDOW 'PREMODERN-BUTTONEVENTFN)
+ (WINDOWPROP WINDOW 'BUTTONEVENTFN (WINDOWPROP WINDOW 'PREMODERN-BUTTONEVENTFN))
+ (WINDOWPROP WINDOW 'PREMODERN-BUTTONEVENTFN NIL))
+ (WINDOWPROP WINDOW 'PREMODERN-BUTTONEVENTFN (WINDOWPROP WINDOW 'BUTTONEVENTFN))
+ (WINDOWPROP WINDOW 'BUTTONEVENTFN (IF (OR ANYWHERE TITLEPROPORTION)
is some kind of visual feedback possible of which window titlebars and corners can or can't be buttoned?
Does MODERNIZE work with Rooms?
In lispusers/MODERNIZE <#348 (comment)>:
> @@ -1,11 +1,11 @@
-(DEFINE-FILE-INFO READTABLE "INTERLISP" PACKAGE "INTERLISP")
-(FILECREATED "14-Mar-2021 20:33:34"
-{DSK}<Users>kaplan>Local>medley3.5>git-medley>lispusers>MODERNIZE.;14 20950
shouldn't this move to Library? Basically anything that is part of FULL.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#348 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJLCFAJTOOXJOWGQWLTTZDRHJANCNFSM47OWLHAA>.
|
masinter
requested changes
Jul 23, 2021
There was a problem hiding this comment.
while there are a lot of "cosmetic" issues (bad pretty printing, edit comments lost, etc) there are a few more serious issues. I think it's necessary to sort out the "Masterscope gives error on ambiguous record field" changes from the "support external character encoding". The former could be fixed by adding a per-file record priority list, removing the necessity of any source edits. And the READTABLE should be independent of the file encoding. READ works on a stream of characters, which remain the same character independent of whether they are encoded in XCCS, UTF-8, ISO8059-10 or what have you.
I propose using this branch as a model, and bringing forward changes one at a time starting with current master.
| (DECLARE%: EVAL@COMPILE DONTCOPY | ||
| (DECLARE%: EVAL@COMPILE | ||
|
|
||
| (RPAQQ UP 156) |
There was a problem hiding this comment.
i'm wary about using such common words for constants. WS-UP, WS-DOWN etc?
|
|
||
| (DEFMACRO WITH-READER-ENVIRONMENT (ENV . BODY) | ||
| `((CL:LAMBDA (E) | ||
| (LET ((*PACKAGE* (ffetch (READER-ENVIRONMENT REPACKAGE) of E)) | ||
| (*READTABLE* (ffetch (READER-ENVIRONMENT REREADTABLE) of E)) | ||
| (*READ-BASE* (ffetch (READER-ENVIRONMENT REBASE) of E)) | ||
| (*PRINT-BASE* (ffetch (READER-ENVIRONMENT REBASE) of E))) | ||
| (*PRINT-BASE* (ffetch (READER-ENVIRONMENT REBASE) of E)) | ||
| (*EXTERNALFORMAT* (ffetch (READER-ENVIRONMENT REFORMAT) of E))) |
There was a problem hiding this comment.
where are the other variables declared SPECIAL? Why just the external format? Is this really at the right level? The other elements don't depend / vary when you change XCCS and UTF-8... they're EXTERNAL-FORMAT independent
|
With respect to CMLREAD, the other variables are the variables that define the current default readtabe, package, and base, when you call IO functions with those not locally specified. I presume that there are global declarations somewhere that they are specvars.
I added the external format as another variable, when I thought that it was of the same sort and that was the right thing to do. But it isn’t, the external format is a property of the stream itself, not of the printing environment. So that variable is really not interpreted—the external format is installed specifically when the stream is opened or the user changes it by STREAMPROP or SETFILEINFO.
To make it operate implicitly as part of the context set by this macro, a further change would have been to have this reset the format of the stream under a resetsave and restore the previous external format on exit. But the problem is that this macro doesn’t actually take the stream as an argument, it just sets these variables for any and all printing/reading to any and all streams underneath.
(Note also that setting the format changes all 5 of the primitive character reading/writing functions in the stream. It’s a level below whether or not a given internal character is a sepr in this context, or a package identifier should be printed.)
(Note also: I have no idea why this was in CMLREAD)
… On Jul 23, 2021, at 11:40 AM, Larry Masinter ***@***.***> wrote:
@masinter requested changes on this pull request.
while there are a lot of "cosmetic" issues (bad pretty printing, edit comments lost, etc) there are a few more serious issues. I think it's necessary to sort out the "Masterscope gives error on ambiguous record field" changes from the "support external character encoding". The former could be fixed by adding a per-file record priority list, removing the necessity of any source edits. And the READTABLE should be independent of the file encoding. READ works on a stream of characters, which remain the same character independent of whether they are encoded in XCCS, UTF-8, ISO8059-10 or what have you.
I propose using this branch as a model, and bringing forward changes one at a time starting with current master.
In lispusers/PRETTYFILEINDEX <#348 (comment)>:
> @@ -181,7 +183,8 @@ Copyright (c) 1988, 1992, 1993, 1999 by Xerox Corporation. All rights reserved.
(DEFINEQ
(PRETTYFILEINDEX
- [LAMBDA (FILENAME PRINTOPTIONS OUTSTREAM DONTINDEX) (* ; "Edited 11-Apr-95 00:02 by rmk:")
we should fix ALL the copyright notices
In lispusers/PRETTYFILEINDEX <#348 (comment)>:
> @@ -181,7 +183,8 @@ Copyright (c) 1988, 1992, 1993, 1999 by Xerox Corporation. All rights reserved.
(DEFINEQ
(PRETTYFILEINDEX
- [LAMBDA (FILENAME PRINTOPTIONS OUTSTREAM DONTINDEX) (* ; "Edited 11-Apr-95 00:02 by rmk:")
+ [LAMBDA (FILENAME PRINTOPTIONS OUTSTREAM DONTINDEX) (* ; "Edited 9-Jul-2021 21:35 by rmk:")
... and edit dates, before they get lost
In lispusers/WHEELSCROLL <#348 (comment)>:
> (GLOBALVARS WHEELSCROLLDELTA WHEELSCROLLSETTLETIME \WHEELSCROLLINPROGRESS)
- (INITVARS (WHEELSCROLLDELTA 20)
+
+ (* ;; "To restore the keyactions for PAD..., if the keyaction table has been reinitialized")
+
+ [ADDVARS (AFTERSYSOUTFORMS (AND WHEELSCROLLENABLED (ENABLEWHEELSCROLL T)))
It's not just "after sysout": there are four events: sysout, makesys, logout, savevm which have before, after, and (for all except LOGOUT) "after doing". And this triggers a "DEVICEEVENT" (need to check on the details)
In lispusers/WHEELSCROLL <#348 (comment)>:
> - T)
- (521 (WHEELSCROLL 'VERTICAL (IMINUS WHEELSCROLLDELTA))
- T)
- (522 (WHEELSCROLL 'HORIZONTAL (IMINUS WHEELSCROLLDELTA)
- T))
- (523 (WHEELSCROLL 'HORIZONTAL WHEELSCROLLDELTA T))))
+
+
+(* ;;
+"These are the highest meta-ctrl characters, they will be unaffected by teh state of ctrl and meta mode keys"
+)
+
+(DECLARE%: ***@***.*** DONTCOPY
+(DECLARE%: ***@***.***
+
+(RPAQQ UP 156)
i'm wary about using such common words for constants. WS-UP, WS-DOWN etc?
In sources/ABASIC <#348 (comment)>:
> (VARS (\IMAX.FLOAT (FIX MAX.FLOAT))
(\IMIN.FLOAT (FIX MIN.FLOAT)))
(GLOBALVARS \IMAX.FLOAT \IMIN.FLOAT))
(DECLARE%: ***@***.*** ***@***.*** DONTCOPY COMPILERVARS
(ADDVARS (NLAMA DUMMYDEF)
(NLAML)
- (LAMA LIST* LIST NCONC NOTIMP ZERO TRUE NILL])
I wonder if LAMA is needed ? It might be a remnant from Interlisp-10 which compiled calls to (LAMBDA N ...) functions differently than calls to (LAMBDA (...) ...) functions.
In sources/ABASIC <#348 (comment)>:
> @@ -62,7 +64,7 @@ Copyright (c) 1982, 1983, 1984, 1985, 1986, 1987, 1990 by Venue & Xerox Corporat
(DEFINEQ
(NILL
- [LAMBDA NOBIND (* lmm " 4-OCT-83 03:05")
logically, this is the wrong place to fix the NOBIND error. Some bell is ringing about checking common lisp function calls in the ANSI standard Common Lisp
In sources/ADISPLAY <#348 (comment)>:
>
(DECLARE (LOCALVARS . T))
- [COND
cant tell what changed here or why...
In sources/AOFD <#348 (comment)>:
> @@ -334,9 +335,10 @@ Copyright (c) 1981, 1982, 1983, 1984, 1985, 1986, 1987, 1990 by Venue & Xerox Co
(\DEFINEDEVICE NIL \BASEBYTESDEVICE])
(\MAKEBASEBYTESTREAM
- [LAMBDA (BASE OFFST LEN ACCESS WRITEXTENSIONFN OSTREAM) (* ; "Edited 17-Jan-87 16:08 by bvm:")
-
- (* ;; "If an error is to occur due to non-numeric arg or range restrictions, then let it happen outside the UNINTERRUPTABLY")
+ [LAMBDA (BASE OFFST LEN ACCESS WRITEXTENSIONFN OSTREAM)
why the pair of font control changes (4 instead of two) father the OSTREM) ? Curious
In sources/AOFD <#348 (comment)>:
> - (replace ACCESS of OSTREAM with ACCESS)
-
- (* ;; "Insures that the BINABLE BOUTABLE and EXTENDABLE bits are setup setup, and that the correct BIN and BOUT fns are 'inherited' from the FDEV as well")
-
- (freplace FULLFILENAME of OSTREAM with NIL)
- (freplace OUTCHARFN of OSTREAM with (FUNCTION \MBS.OUTCHARFN))
- (freplace LINELENGTH of OSTREAM with 0)
- (freplace CHARPOSITION of OSTREAM with 0)
- (freplace WRITEXTENSIONFN of OSTREAM with (SELECTQ ACCESS
- ((OUTPUT BOTH)
- WRITEXTENSIONFN)
- NIL))
- (freplace BBSNCHARS of OSTREAM with 0))
+ (freplace (STREAM USERCLOSEABLE) of OSTREAM with NIL)
+ (freplace (STREAM USERVISIBLE) of OSTREAM with NIL)
+ (freplace (STREAM BYTESIZE) of OSTREAM with BITSPERBYTE)
BItSPERBYTE is a variable (8 or 9) ?
In sources/AOFD <#348 (comment)>:
> )
(DECLARE%: DONTCOPY
-(* "FOLLOWING DEFINITIONS EXPORTED")
-
-(DECLARE%: ***@***.***
+(* "FOLLOWING DEFINITIONS EXPORTED")(DECLARE%: ***@***.***
odd reformatting of EXPORTS comment
In sources/ATBL <#348 (comment)>:
> @@ -1863,24 +1874,24 @@ Copyright (c) 1982, 1983, 1984, 1985, 1986, 1987, 1990, 1993, 2018, 2021 by Venu
(PUTPROPS ATBL COPYRIGHT ("Venue & Xerox Corporation" 3676Q 3677Q 3700Q 3701Q 3702Q 3703Q 3706Q 3711Q
why are numbers in this file printed in Octal?
In sources/CMLREAD <#348 (comment)>:
>
(DEFMACRO WITH-READER-ENVIRONMENT (ENV . BODY)
`((CL:LAMBDA (E)
(LET ((*PACKAGE* (ffetch (READER-ENVIRONMENT REPACKAGE) of E))
(*READTABLE* (ffetch (READER-ENVIRONMENT REREADTABLE) of E))
(*READ-BASE* (ffetch (READER-ENVIRONMENT REBASE) of E))
- (*PRINT-BASE* (ffetch (READER-ENVIRONMENT REBASE) of E)))
+ (*PRINT-BASE* (ffetch (READER-ENVIRONMENT REBASE) of E))
+ (*EXTERNALFORMAT* (ffetch (READER-ENVIRONMENT REFORMAT) of E)))
where are the other variables declared SPECIAL? Why just the external format? Is this really at the right level? The other elements don't depend / vary when you change XCCS and UTF-8... they're EXTERNAL-FORMAT independent
In sources/CMLREAD <#348 (comment)>:
> (DECLARE%: ***@***.*** DONTCOPY
(GLOBALVARS *COMMON-LISP-READ-ENVIRONMENT*)
)
(RPAQ? *COMMON-LISP-READ-ENVIRONMENT* (create READER-ENVIRONMENT REPACKAGE _ (CL:FIND-PACKAGE
"USER")
- REREADTABLE _ CMLRDTBL REBASE _ 10))
same ... common lisp vs. interlisp readtable shouldn't change the "stream" properties.
In sources/EXTERNALFORMAT.TXT <#348 (comment)>:
> @@ -0,0 +1,70 @@
+New architecture for character input-output and alternative external formats
we really need to put together a Medley 4 release manual, formatted and fixed up
In sources/FASLOAD <#348 (comment)>:
>
- IL:|changes| IL:|to:| (IL:FNS CONVERT-FASL-DATE)
This is really illegible IL:|changes| IL:|to:|
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#348 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJMCWH24XW4ARKNLIL3TZGZTLANCNFSM47OWLHAA>.
|
|
Also, the externalformat.txt document reflects an earlier stage of the migration from what I inherited and where I ended up. I’ll do an update when this settles down. (After this merge, there are a few minor cleanups (rationalizing a few of the naming conventions, maybe even taking the format variable out of the WITH-READER-ENVIRONMENT) still to do.)
… On Jul 23, 2021, at 11:40 AM, Larry Masinter ***@***.***> wrote:
@masinter requested changes on this pull request.
while there are a lot of "cosmetic" issues (bad pretty printing, edit comments lost, etc) there are a few more serious issues. I think it's necessary to sort out the "Masterscope gives error on ambiguous record field" changes from the "support external character encoding". The former could be fixed by adding a per-file record priority list, removing the necessity of any source edits. And the READTABLE should be independent of the file encoding. READ works on a stream of characters, which remain the same character independent of whether they are encoded in XCCS, UTF-8, ISO8059-10 or what have you.
I propose using this branch as a model, and bringing forward changes one at a time starting with current master.
In lispusers/PRETTYFILEINDEX <#348 (comment)>:
> @@ -181,7 +183,8 @@ Copyright (c) 1988, 1992, 1993, 1999 by Xerox Corporation. All rights reserved.
(DEFINEQ
(PRETTYFILEINDEX
- [LAMBDA (FILENAME PRINTOPTIONS OUTSTREAM DONTINDEX) (* ; "Edited 11-Apr-95 00:02 by rmk:")
we should fix ALL the copyright notices
In lispusers/PRETTYFILEINDEX <#348 (comment)>:
> @@ -181,7 +183,8 @@ Copyright (c) 1988, 1992, 1993, 1999 by Xerox Corporation. All rights reserved.
(DEFINEQ
(PRETTYFILEINDEX
- [LAMBDA (FILENAME PRINTOPTIONS OUTSTREAM DONTINDEX) (* ; "Edited 11-Apr-95 00:02 by rmk:")
+ [LAMBDA (FILENAME PRINTOPTIONS OUTSTREAM DONTINDEX) (* ; "Edited 9-Jul-2021 21:35 by rmk:")
... and edit dates, before they get lost
In lispusers/WHEELSCROLL <#348 (comment)>:
> (GLOBALVARS WHEELSCROLLDELTA WHEELSCROLLSETTLETIME \WHEELSCROLLINPROGRESS)
- (INITVARS (WHEELSCROLLDELTA 20)
+
+ (* ;; "To restore the keyactions for PAD..., if the keyaction table has been reinitialized")
+
+ [ADDVARS (AFTERSYSOUTFORMS (AND WHEELSCROLLENABLED (ENABLEWHEELSCROLL T)))
It's not just "after sysout": there are four events: sysout, makesys, logout, savevm which have before, after, and (for all except LOGOUT) "after doing". And this triggers a "DEVICEEVENT" (need to check on the details)
In lispusers/WHEELSCROLL <#348 (comment)>:
> - T)
- (521 (WHEELSCROLL 'VERTICAL (IMINUS WHEELSCROLLDELTA))
- T)
- (522 (WHEELSCROLL 'HORIZONTAL (IMINUS WHEELSCROLLDELTA)
- T))
- (523 (WHEELSCROLL 'HORIZONTAL WHEELSCROLLDELTA T))))
+
+
+(* ;;
+"These are the highest meta-ctrl characters, they will be unaffected by teh state of ctrl and meta mode keys"
+)
+
+(DECLARE%: ***@***.*** DONTCOPY
+(DECLARE%: ***@***.***
+
+(RPAQQ UP 156)
i'm wary about using such common words for constants. WS-UP, WS-DOWN etc?
In sources/ABASIC <#348 (comment)>:
> (VARS (\IMAX.FLOAT (FIX MAX.FLOAT))
(\IMIN.FLOAT (FIX MIN.FLOAT)))
(GLOBALVARS \IMAX.FLOAT \IMIN.FLOAT))
(DECLARE%: ***@***.*** ***@***.*** DONTCOPY COMPILERVARS
(ADDVARS (NLAMA DUMMYDEF)
(NLAML)
- (LAMA LIST* LIST NCONC NOTIMP ZERO TRUE NILL])
I wonder if LAMA is needed ? It might be a remnant from Interlisp-10 which compiled calls to (LAMBDA N ...) functions differently than calls to (LAMBDA (...) ...) functions.
In sources/ABASIC <#348 (comment)>:
> @@ -62,7 +64,7 @@ Copyright (c) 1982, 1983, 1984, 1985, 1986, 1987, 1990 by Venue & Xerox Corporat
(DEFINEQ
(NILL
- [LAMBDA NOBIND (* lmm " 4-OCT-83 03:05")
logically, this is the wrong place to fix the NOBIND error. Some bell is ringing about checking common lisp function calls in the ANSI standard Common Lisp
In sources/ADISPLAY <#348 (comment)>:
>
(DECLARE (LOCALVARS . T))
- [COND
cant tell what changed here or why...
In sources/AOFD <#348 (comment)>:
> @@ -334,9 +335,10 @@ Copyright (c) 1981, 1982, 1983, 1984, 1985, 1986, 1987, 1990 by Venue & Xerox Co
(\DEFINEDEVICE NIL \BASEBYTESDEVICE])
(\MAKEBASEBYTESTREAM
- [LAMBDA (BASE OFFST LEN ACCESS WRITEXTENSIONFN OSTREAM) (* ; "Edited 17-Jan-87 16:08 by bvm:")
-
- (* ;; "If an error is to occur due to non-numeric arg or range restrictions, then let it happen outside the UNINTERRUPTABLY")
+ [LAMBDA (BASE OFFST LEN ACCESS WRITEXTENSIONFN OSTREAM)
why the pair of font control changes (4 instead of two) father the OSTREM) ? Curious
In sources/AOFD <#348 (comment)>:
> - (replace ACCESS of OSTREAM with ACCESS)
-
- (* ;; "Insures that the BINABLE BOUTABLE and EXTENDABLE bits are setup setup, and that the correct BIN and BOUT fns are 'inherited' from the FDEV as well")
-
- (freplace FULLFILENAME of OSTREAM with NIL)
- (freplace OUTCHARFN of OSTREAM with (FUNCTION \MBS.OUTCHARFN))
- (freplace LINELENGTH of OSTREAM with 0)
- (freplace CHARPOSITION of OSTREAM with 0)
- (freplace WRITEXTENSIONFN of OSTREAM with (SELECTQ ACCESS
- ((OUTPUT BOTH)
- WRITEXTENSIONFN)
- NIL))
- (freplace BBSNCHARS of OSTREAM with 0))
+ (freplace (STREAM USERCLOSEABLE) of OSTREAM with NIL)
+ (freplace (STREAM USERVISIBLE) of OSTREAM with NIL)
+ (freplace (STREAM BYTESIZE) of OSTREAM with BITSPERBYTE)
BItSPERBYTE is a variable (8 or 9) ?
In sources/AOFD <#348 (comment)>:
> )
(DECLARE%: DONTCOPY
-(* "FOLLOWING DEFINITIONS EXPORTED")
-
-(DECLARE%: ***@***.***
+(* "FOLLOWING DEFINITIONS EXPORTED")(DECLARE%: ***@***.***
odd reformatting of EXPORTS comment
In sources/ATBL <#348 (comment)>:
> @@ -1863,24 +1874,24 @@ Copyright (c) 1982, 1983, 1984, 1985, 1986, 1987, 1990, 1993, 2018, 2021 by Venu
(PUTPROPS ATBL COPYRIGHT ("Venue & Xerox Corporation" 3676Q 3677Q 3700Q 3701Q 3702Q 3703Q 3706Q 3711Q
why are numbers in this file printed in Octal?
In sources/CMLREAD <#348 (comment)>:
>
(DEFMACRO WITH-READER-ENVIRONMENT (ENV . BODY)
`((CL:LAMBDA (E)
(LET ((*PACKAGE* (ffetch (READER-ENVIRONMENT REPACKAGE) of E))
(*READTABLE* (ffetch (READER-ENVIRONMENT REREADTABLE) of E))
(*READ-BASE* (ffetch (READER-ENVIRONMENT REBASE) of E))
- (*PRINT-BASE* (ffetch (READER-ENVIRONMENT REBASE) of E)))
+ (*PRINT-BASE* (ffetch (READER-ENVIRONMENT REBASE) of E))
+ (*EXTERNALFORMAT* (ffetch (READER-ENVIRONMENT REFORMAT) of E)))
where are the other variables declared SPECIAL? Why just the external format? Is this really at the right level? The other elements don't depend / vary when you change XCCS and UTF-8... they're EXTERNAL-FORMAT independent
In sources/CMLREAD <#348 (comment)>:
> (DECLARE%: ***@***.*** DONTCOPY
(GLOBALVARS *COMMON-LISP-READ-ENVIRONMENT*)
)
(RPAQ? *COMMON-LISP-READ-ENVIRONMENT* (create READER-ENVIRONMENT REPACKAGE _ (CL:FIND-PACKAGE
"USER")
- REREADTABLE _ CMLRDTBL REBASE _ 10))
same ... common lisp vs. interlisp readtable shouldn't change the "stream" properties.
In sources/EXTERNALFORMAT.TXT <#348 (comment)>:
> @@ -0,0 +1,70 @@
+New architecture for character input-output and alternative external formats
we really need to put together a Medley 4 release manual, formatted and fixed up
In sources/FASLOAD <#348 (comment)>:
>
- IL:|changes| IL:|to:| (IL:FNS CONVERT-FASL-DATE)
This is really illegible IL:|changes| IL:|to:|
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#348 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJMCWH24XW4ARKNLIL3TZGZTLANCNFSM47OWLHAA>.
|
|
Can we at least (a) implement some "unit tests" that makes sure the UTF-8 code is working? Preferably something that can be automated? |
This was referenced Jul 29, 2021
Closed
|
no longer needed; was turned to draft after merging to make sure issues raised / tested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is ready for more general testing and eventual merging. It isolates the XCCS/NS external format dependencies into one new file XCCS, and all character access then goes through a few abstract functional interfaces (\INCCODE, \PEEKCCODE...), with the XCCS implementations still set up as the default.
This required touching and recompiling lots of files, but it all seems to hang together in this full sysout and in the LFG system built on top.
Other improvements/fixes to MODERNIZE, WHEELSCROLL, CLIPBOARD, and others.