Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update of cardano-cli to 8.21.0.0 and cardano-api to 8.42.0.0, delete custom cardano-git-rev #5716

Merged
merged 11 commits into from
Mar 28, 2024
Merged

Update of cardano-cli to 8.21.0.0 and cardano-api to 8.42.0.0, delete custom cardano-git-rev #5716

merged 11 commits into from
Mar 28, 2024

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Mar 14, 2024 •
edited
Loading

Description

This PR updates cardano-cli to 8.21.0.0 and cardano-api to 8.42.0.0.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The version bounds in .cabal files are updated
  • CI passes.
  • Self-reviewed the diff

@palas palas force-pushed the smelc/update-cardano-cli-and-cardano-api branch from ba3d18a to de0fd2c Compare March 14, 2024 22:24
@smelc smelc force-pushed the smelc/update-cardano-cli-and-cardano-api branch from 043c48c to 9d99d54 Compare March 22, 2024 08:50
@smelc smelc changed the title Prepare update of cardano-cli to TODO and cardano-api to 8.40.0.0 Prepare update of cardano-cli to 8.21.0.0 and cardano-api to 8.40.0.0 Mar 26, 2024
@smelc smelc changed the title Prepare update of cardano-cli to 8.21.0.0 and cardano-api to 8.40.0.0 Prepare update of cardano-cli to 8.21.0.0 and cardano-api to 8.42.0.0 Mar 26, 2024
@smelc smelc force-pushed the smelc/update-cardano-cli-and-cardano-api branch from 7bf692d to 4c54588 Compare March 26, 2024 10:54
@smelc smelc marked this pull request as ready for review March 26, 2024 12:47
@smelc smelc requested review from a team as code owners March 26, 2024 12:47
@smelc smelc changed the title Prepare update of cardano-cli to 8.21.0.0 and cardano-api to 8.42.0.0 Update of cardano-cli to 8.21.0.0 and cardano-api to 8.42.0.0, delete custom cardano-git-rev Mar 26, 2024
@smelc smelc force-pushed the smelc/update-cardano-cli-and-cardano-api branch 2 times, most recently from bab8f9f to f675763 Compare March 26, 2024 14:15
@smelc smelc force-pushed the smelc/update-cardano-cli-and-cardano-api branch 2 times, most recently from 63c2e6a to 7727190 Compare March 26, 2024 14:38
@smelc smelc enabled auto-merge March 26, 2024 14:45
@smelc smelc disabled auto-merge March 26, 2024 15:38
@smelc smelc marked this pull request as draft March 26, 2024 15:39
@smelc
Copy link
Contributor Author

smelc commented Mar 26, 2024

Setting to draft again, as I need to adapt cardano-testnet to changes to cardano-cli conway create-testnet-data .... Stay tuned.

Jimbo4350
Jimbo4350 reviewed Mar 26, 2024
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be sure to get the benchmarking team's review @mgmeier

@smelc smelc force-pushed the smelc/update-cardano-cli-and-cardano-api branch from 04e256a to 1cc1ee6 Compare March 27, 2024 09:17
@smelc smelc mentioned this pull request Mar 27, 2024
Open
9 tasks
@smelc smelc marked this pull request as ready for review March 27, 2024 14:56
@smelc smelc added this pull request to the merge queue Mar 28, 2024
Merged via the queue into master with commit 8430590 Mar 28, 2024
28 checks passed
@smelc smelc deleted the smelc/update-cardano-cli-and-cardano-api branch March 28, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 left review comments

@carbolymer carbolymer carbolymer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@smelc @carbolymer @Jimbo4350 @erikd @hamishmack