Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index state #5856

Merged
merged 1 commit into from
May 29, 2024
Merged

Update index state #5856

merged 1 commit into from
May 29, 2024

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented May 26, 2024

Description

The additional constraint in cabal.project is explained in a comment below.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy marked this pull request as ready for review May 26, 2024 05:20
@newhoggy newhoggy requested a review from a team as a code owner May 26, 2024 05:20
@newhoggy newhoggy force-pushed the newhoggy/update-index-state branch from 1650f0e to c2eff4a Compare May 26, 2024 06:10
cabal.project Outdated
@@ -54,6 +54,9 @@ package bitvec
package plutus-scripts-bench
haddock-options: "--optghc=-fplugin-opt PlutusTx.Plugin:defer-errors"

constraints:
io-classes-mtl < 0.1.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? can you add a comment explaining why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't include it you get this error:

src/Control/Monad/Class/MonadSTM/Trans.hs:116:5: error: [GHC-54721]
    ‘writeTMVar’ is not a (visible) method of class ‘MonadSTM’
    |
116 |     writeTMVar     = ContTSTM .: writeTMVar
    |     ^^^^^^^^^^

src/Control/Monad/Class/MonadSTM/Trans.hs:194:5: error: [GHC-54721]
    ‘writeTMVar’ is not a (visible) method of class ‘MonadSTM’
    |
194 |     writeTMVar     = lift .: writeTMVar
    |     ^^^^^^^^^^

src/Control/Monad/Class/MonadSTM/Trans.hs:272:5: error: [GHC-54721]
    ‘writeTMVar’ is not a (visible) method of class ‘MonadSTM’
    |
272 |     writeTMVar     = lift .: writeTMVar
    |     ^^^^^^^^^^

src/Control/Monad/Class/MonadSTM/Trans.hs:350:5: error: [GHC-54721]
    ‘writeTMVar’ is not a (visible) method of class ‘MonadSTM’
    |
350 |     writeTMVar     = lift .: writeTMVar
    |     ^^^^^^^^^^

src/Control/Monad/Class/MonadSTM/Trans.hs:428:5: error: [GHC-54721]
    ‘writeTMVar’ is not a (visible) method of class ‘MonadSTM’
    |
428 |     writeTMVar     = lift .: writeTMVar
    |     ^^^^^^^^^^

src/Control/Monad/Class/MonadSTM/Trans.hs:506:5: error: [GHC-54721]
    ‘writeTMVar’ is not a (visible) method of class ‘MonadSTM’
    |
506 |     writeTMVar     = lift .: writeTMVar
    |     ^^^^^^^^^^

src/Control/Monad/Class/MonadSTM/Trans.hs:584:5: error: [GHC-54721]
    ‘writeTMVar’ is not a (visible) method of class ‘MonadSTM’
    |
584 |     writeTMVar     = lift .: writeTMVar
    |     ^^^^^^^^^^

src/Control/Monad/Class/MonadSTM/Trans.hs:662:5: error: [GHC-54721]
    ‘writeTMVar’ is not a (visible) method of class ‘MonadSTM’
    |
662 |     writeTMVar     = lift .: writeTMVar
    |     ^^^^^^^^^^

This is just changes in the definition of type classes in our dependencies that break other dependencies. When all our other dependencies update accordingly we can remove this constraint.

@newhoggy newhoggy added this pull request to the merge queue May 28, 2024
@newhoggy newhoggy removed this pull request from the merge queue due to a manual request May 28, 2024
@newhoggy newhoggy force-pushed the newhoggy/update-index-state branch 2 times, most recently from eb4fd39 to cbda256 Compare May 28, 2024 11:40
@newhoggy newhoggy requested review from a team as code owners May 28, 2024 11:40
@newhoggy newhoggy force-pushed the newhoggy/update-index-state branch 3 times, most recently from 289289f to 51ca7e2 Compare May 28, 2024 13:17
@newhoggy newhoggy enabled auto-merge May 28, 2024 13:21
@newhoggy newhoggy force-pushed the newhoggy/update-index-state branch 2 times, most recently from 6024df8 to d2ca428 Compare May 29, 2024 13:26
@newhoggy newhoggy force-pushed the newhoggy/update-index-state branch from d2ca428 to 36985ac Compare May 29, 2024 13:46
@newhoggy newhoggy added this pull request to the merge queue May 29, 2024
@disassembler disassembler removed this pull request from the merge queue due to a manual request May 29, 2024
@disassembler disassembler merged commit a5baa39 into master May 29, 2024
24 checks passed
@disassembler disassembler deleted the newhoggy/update-index-state branch May 29, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants