Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually Island Create on Join #765

Merged
merged 3 commits into from
Nov 11, 2023
Merged

Actually Island Create on Join #765

merged 3 commits into from
Nov 11, 2023

Conversation

sh0inx
Copy link
Contributor

@sh0inx sh0inx commented Nov 11, 2023

i am bad at github sorry

public void onPlayerJoin(PlayerJoinEvent event) {
if(IridiumSkyblock.getInstance().getConfiguration().islandCreateOnJoin && !event.getPlayer().hasPlayedBefore())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we wana check if they have an island isntead of seeing if they played before?

I guess the difference is if they create an island, delete the island and then relog, should it make a new one for them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the idea is to have the server put them in the create menu as soon as they join the server for the first time, we could add a config option for if the server wants to bring this prompt up after island deletion and rejoin but I feel that it may be a lil bit unnecessary considering they already have experience with the server/plugin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because the create menu is skipped on a single schematic, I imagine this will also just create an island for them if they don't have one, which they won't because it's their first join

@PeachesMLG PeachesMLG merged commit a3fa3fc into master Nov 11, 2023
3 of 4 checks passed
@PeachesMLG PeachesMLG deleted the create-island-on-join branch November 11, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants