Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually Island Create on Join #765

Merged
merged 3 commits into from
Nov 11, 2023
Merged

Actually Island Create on Join #765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e258a8
push this please this is embarrassing
sh0inx Nov 11, 2023
75a7b22
updated to not call listener twice and set priority to monitor
sh0inx Nov 11, 2023
5590ada
Merge branch 'master' into create-island-on-join
PeachesMLG Nov 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/com/iridium/iridiumskyblock/configs/Configuration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ public Configuration() {
public boolean clearInventoryOnRegen = false;
public boolean clearEnderChestOnRegen = false;
public boolean allowPvPOnIslands = false;
public boolean islandCreateOnJoin = false;
public int distance = 151;
public int netherUnlockLevel = 10;
public int endUnlockLevel = 20;
Expand Down
8 changes: 6 additions & 2 deletions src/main/java/com/iridium/iridiumskyblock/listeners/PlayerJoinListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,19 @@
package com.iridium.iridiumskyblock.listeners;

import com.iridium.iridiumskyblock.IridiumSkyblock;
import org.bukkit.Bukkit;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;

public class PlayerJoinListener implements Listener {

@EventHandler
@EventHandler (priority = EventPriority.MONITOR)
public void onPlayerJoin(PlayerJoinEvent event) {
if(IridiumSkyblock.getInstance().getConfiguration().islandCreateOnJoin && !event.getPlayer().hasPlayedBefore())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we wana check if they have an island isntead of seeing if they played before?

I guess the difference is if they create an island, delete the island and then relog, should it make a new one for them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the idea is to have the server put them in the create menu as soon as they join the server for the first time, we could add a config option for if the server wants to bring this prompt up after island deletion and rejoin but I feel that it may be a lil bit unnecessary considering they already have experience with the server/plugin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because the create menu is skipped on a single schematic, I imagine this will also just create an island for them if they don't have one, which they won't because it's their first join

Bukkit.getServer().dispatchCommand(event.getPlayer(), "is create");

IridiumSkyblock.getInstance().getTeamManager().sendIslandBorder(event.getPlayer());
}

}
Loading