Implement Markdown tables support (GFM extension) #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BasicTableLayout is a simple table layout that lives in foundation. It does not have styling (that'll be implemented in the ui layer) but does all we need for Markdown, and other similar basic scenarios. It is not lazy and its performances can surely be improved, but it works.
By making the MarkdownProcessor's extensions and CommonMark Parser properties public, they are now accessible to extensions directly from the processor itself, eliminating the need to pass them explicitly. This, in turn, makes it possible to implement more complex extensions as stateless objects, instead of stateful classes, further simplifying the implementation and usage of extensions.
Add an experimental operator fun plus(extension) to MarkdownProcessor and MarkdownBlockRenderer that allows users to easily create a copy of either with an additional extension, if they need to.
We now have tables :) Also make the image in there local, and pass ImageOptim on the other pics in art/docs for good measure (and faster loading).
It's completely unnecessary for our needs.
rock3r
added
new component
hamen
approved these changes
Dec 20, 2024
Closed
hamen
added a commit
to rock3r/intellij-community
that referenced
this pull request
Jan 16, 2025
Reference JetBrains/jewel#735 Signed-off-by: Ivan Morgillo <[email protected]>
rock3r
pushed a commit
to rock3r/intellij-community
that referenced
this pull request
Jan 20, 2025
rock3r
pushed a commit
to rock3r/intellij-community
that referenced
this pull request
Jan 20, 2025
|
Superseded by JetBrains/intellij-community#2913 |
rock3r
pushed a commit
to rock3r/intellij-community
that referenced
this pull request
Jan 21, 2025
rock3r
pushed a commit
to rock3r/intellij-community
that referenced
this pull request
Jan 21, 2025
rock3r
pushed a commit
to rock3r/intellij-community
that referenced
this pull request
Jan 21, 2025
rock3r
pushed a commit
to rock3r/intellij-community
that referenced
this pull request
Jan 21, 2025
rock3r
pushed a commit
to rock3r/intellij-community
that referenced
this pull request
Jan 22, 2025
This was referenced Jan 28, 2025
hamen
added a commit
to rock3r/intellij-community
that referenced
this pull request
Jan 30, 2025
hamen
added a commit
to rock3r/intellij-community
that referenced
this pull request
Jan 30, 2025
Reference JetBrains/jewel#735 Signed-off-by: Ivan Morgillo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the GFM tables extension in the Markdown renderer. At a high level:
SimpleTableLayout(see its kdoc)GitHubTableProcessorExtensionandGitHubTableRendererExtensioncommonmark-ext-gfm-tablesto parse the table markupMarkdownProcessorand adding an experimental+operator to it, for extensions