Multi-monitor support #11
Conversation
When a window produces an error message, display the error as a message for the same window.
To aid in easier development workflow, the theme directory and config path can be overwritten with environment variables to avoid having to run `node make install` after changes to themes to test them, and to allow for a separate configuration file for development and testing, so that nody-greeter can continue to be used as the primary greeter on a system with sensible & safe config
Using --no-install ensures that the local node_modules version of typescript is used, and that an error is thrown if it's not installed for some reason
Given that this functionality is unique to nody-greeter, a new class / namespace has been created under `nody_greeter` that includes the ability to get this information, to allow for the existing interfaces to remain backwards-compatible with web-greeter
All other monitors will continue to display the wallpaper for the theme.
|
Thanks for the initial review! Also noticed you introduced linting and formatting, very nice to see! I've incorporated your suggestions in a rebase, and also ensured that it's formatted + linted throughout the history. I also spotted a bug where if a frame is reloaded (via ctrl+R, or via theme reloading etc...), then it won't initialize as metadata isn't sent more than once, so i'm going to look at fixing that now by having the theme frame request the metadata and sending it then, tracked this in a TODO above. |
metadata would only be sent once, and not after page refreshes or after reloading the window. To address this, the metadata is caculated once and stored in the windows array, and is requested by the preload script for every window load.
Using the broadcast mechanism ensures that the wallpaper is changed across all screens.
|
Okay I've now updated the PR addressing the refresh bug, and allowing cross-window communication via a broadcast mechanism. This mechanism is then also used in the Other than the open question around handling of a secondary URL, i think this is ready to go now :) |
|
Now, nody-greeter will look for |
|
I just added the Added a "fake" display to test it locally, and yeah, it works! vokoscreenNG-2022-01-15_22-39-26.mov |
There was a problem hiding this comment.
Cool, it will be useful functionality to have a theme config! :-D
Now, nody-greeter will look for
index.theme(still not sure about the name)
Hmm, i'm thinking it should probably end in .yml so that editors will at least pick up the correct syntax-highlighting for people, maybe theme.yml or manifest.yml?
|
|
||
| if (theme_dir.endsWith(".html")) theme_dir = path.dirname(theme_dir); | ||
|
|
||
| if (!fs.existsSync(theme_dir)) { |
There was a problem hiding this comment.
I've just realised thata we're using synchronous / blocking filesystem operations throughout here. It would be better to use async functions, and use await fs.promises, so that we don't freeze the Node.js process.
|
|
|
Just my one comment regarding |
|
Nice~ It looks better and simpler. Now, I'm going to check if there's any issue or anything to be improved before I merge this PR. |
Sweet! Excited to get this in! And thanks for being an easy maintainer to work with! |
Co-authored-by: Sam Lanning <[email protected]>
closes #10
There are a couple of commits I also added to ease development a little bit (638c852, 0d16e9d), I can more them to another PR or just remove if you'd prefer.
This is an initial implementation for multi-monitor support, that seems to be working quite well on my setup. I've included the ability for themes to get metadata about their window, including whether or not they're primary, and have hidden the login components for non-primary screens on the default themes.
I haven't yet implemented cross-window communication, but wanted to get this PR open as a draft before that to make sure that you're happy i'm on the right track. That's the last remaining part, and i'll use the dracula background-switcher as a demo of this functionality.
TODO: