Main: Animation - fix crash w/o keyframes on libc++ (OGRECave#3237)

where lower_bound does not expect distance returning -1
Joilnen · Oct 3, 2024 · 03b0f23 · 03b0f23
1 parent c4328e2
commit 03b0f23
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/OgreMain/src/OgreAnimation.cpp b/OgreMain/src/OgreAnimation.cpp
@@ -607,6 +607,10 @@ namespace Ogre {
         if( timePos > totalAnimationLength && totalAnimationLength > 0.0f )
             timePos = std::fmod( timePos, totalAnimationLength );
 
+        // Not best practice, but prevent from crash
+        if (mKeyFrameTimes.empty())
+            return timePos;
+
         // Search for global index
         auto it = std::lower_bound(mKeyFrameTimes.begin(), mKeyFrameTimes.end() - 1, timePos);
         return TimeIndex(timePos, static_cast<uint>(std::distance(mKeyFrameTimes.begin(), it)));