Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] 상세페이지 신청하기 섹션 구현 #52

Merged
merged 13 commits into from
May 22, 2024

Conversation

mungjin01
Copy link
Collaborator

1️⃣ 요약

  • 상세페이지 신청하기 섹션 구현

3️⃣ 참고사항

  • 가운데 버블 들어갈 섹션은 버블 섹션이라고 지어놓았습니다

4️⃣ 추후 작업

  • 서버 연동

구현 화면

2024-05-19.08-50-36.mp4

@mungjin01 mungjin01 requested a review from AAminha as a code owner May 18, 2024 23:55
@mungjin01 mungjin01 added the ✨Feature 기능 개발 이슈 label May 18, 2024
Copy link
Member

@AAminha AAminha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳굳~~

src/components/ExperienceDetailPage/BubbleSection.tsx Outdated Show resolved Hide resolved
Comment on lines 167 to 176
const Dummy1 = {
imageURL: TestImage,
profileImageURL: TestImage,
participants: 28,
title: '퍼스널 브랜딩, ‘나’를 기획, 디자인하기',
subtitle:
'대한민국은 국제평화의 유지에 노력하고 침략적 전쟁을 부인한다. 국민의 모든 자유와 권리는 국가안전보장·질서유지 또는 공공복리를 위하여 필요한 경우에 한하여 법률로써 제한할 수 있으며.대한민국은 국제평화의 유지에 노력하고 침략적 전쟁을 부인한다.',
profileTitle: '신민선',
profileSubtitle: '콘텐츠 마케터 | 퍼스널브랜딩 | 어쩌구',
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

더미 구성 괜찮은 것 같은데, 상세 소개 이미지랑, 이미지 키워드(방울방울)도 있다는 걸 생각하면 좋을 것 같아요. 그래서 더미를 여기에 두면 안되고, ExperienceDetailPage에서 여기로 props로 넘기는 방식을 선택하면 좋을 것 같습니다.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 근데 profileSubtitle 저렇게 받기로 백엔드랑 협의 됐나요? 저번에 들었을 때는 다 쪼개서 받는다고 했었던 것 같아서요

Copy link
Collaborator Author

@mungjin01 mungjin01 May 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

더미데이터 위치 옮겨야 된다고 생각만 하고 고치지는 않았었네요.. 근데 profileSubtitle 리스트로 넘겨주기로 했는지 한번에 넘겨주기로 했는지 정확히 기억이 안 나서 api 구현된 거 보고 고칠 예정이였습니다..!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오호 일단 알겠습니다

src/components/ExperienceDetailPage/DetailSection.tsx Outdated Show resolved Hide resolved
src/components/common/Modal/modal.tsx Outdated Show resolved Hide resolved
src/pages/ExperienceDetailPage.tsx Show resolved Hide resolved
mungjin01 added a commit that referenced this pull request May 19, 2024
Comment on lines 30 to 40
export const Dummy1 = {
imageURL: TestImage,
profileImageURL: TestImage,
participants: 28,
title: '퍼스널 브랜딩, ‘나’를 기획, 디자인하기',
subtitle:
'대한민국은 국제평화의 유지에 노력하고 침략적 전쟁을 부인한다. 국민의 모든 자유와 권리는 국가안전보장·질서유지 또는 공공복리를 위하여 필요한 경우에 한하여 법률로써 제한할 수 있으며.대한민국은 국제평화의 유지에 노력하고 침략적 전쟁을 부인한다.',
profileTitle: '신민선',
profileSubtitle: '콘텐츠 마케터 | 퍼스널브랜딩 | 어쩌구',
progranURL: TestImage,
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

음.. 지금은 export와 import를 한다고 해도 실제 API를 연동할 땐 데이터를 어떻게 DetailSection으로 넘길 생각인가요?

Copy link
Collaborator Author

@mungjin01 mungjin01 May 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 페이지에 데이터 받은 다음에는

      <DetailSection
        imageURL={data.imageURL!}
        profileImageURL={data.profileImageURL!}
        participants={data.participants!}
        title={data.title!}
        subtitle={data.subtitle!}
        profileTitle={data.profileTitle!}
        profileSubtitle={data.profileSubtitle!}
      />
    )}
    {data.programURL && (
      <ImageSection programURL={data.programURL!} />
    )}`
 

이런 방식으로 넘길 생각입니다..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그러면 지금 이렇게 수정하는 게 좋지 않을까요.....
그리고 ! 단언은 자주 사용하는 건 좋은 방법이 아니라고 해서.. 흠 단언문을 최대한 피할 수 있도록 하면 좋을 것 같아요

src/pages/ExperienceDetailPage.tsx Show resolved Hide resolved
Comment on lines 167 to 176
const Dummy1 = {
imageURL: TestImage,
profileImageURL: TestImage,
participants: 28,
title: '퍼스널 브랜딩, ‘나’를 기획, 디자인하기',
subtitle:
'대한민국은 국제평화의 유지에 노력하고 침략적 전쟁을 부인한다. 국민의 모든 자유와 권리는 국가안전보장·질서유지 또는 공공복리를 위하여 필요한 경우에 한하여 법률로써 제한할 수 있으며.대한민국은 국제평화의 유지에 노력하고 침략적 전쟁을 부인한다.',
profileTitle: '신민선',
profileSubtitle: '콘텐츠 마케터 | 퍼스널브랜딩 | 어쩌구',
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오호 일단 알겠습니다

mungjin01 added a commit that referenced this pull request May 20, 2024
Copy link
Member

@AAminha AAminha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

라우터 쪽에 달아둔 코멘트 한 번만 확인해주세용!! 수고해썽요

Comment on lines +36 to +38
setParticipants((prevParticipants) => prevParticipants + 1);
setButtonDisabled(true);
setModalOpen(false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 API 연동할 때 post 성공하면 실행되는 걸로 하면 될 것 같아요

<Route path="/" element={<HomePage />} />
<Route path="/auth" element={<LoginPage />} />
<Route path="/understand" element={<SelfUnderstandPage />} />
<Route path="/recommend/detail/:id" element={<ExperienceDetailPage />} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지금 라우팅 설정으로 /recommend/detail만 입력하면 홈으로 팅겨나올 수 있어요. 그래서 이런 위험도 줄일 겸 /detail도 굳이 필요하지 않을 것 같아서 recommend/:id로 수정해도 좋을 것 같슴다.

Suggested change
<Route path="/recommend/detail/:id" element={<ExperienceDetailPage />} />
<Route path="/recommend/:id" element={<ExperienceDetailPage />} />

@mungjin01 mungjin01 merged commit 575d9a4 into develop May 22, 2024
@mungjin01 mungjin01 deleted the feature/#51/detail branch May 22, 2024 10:54
mungjin01 added a commit that referenced this pull request May 23, 2024
mungjin01 added a commit that referenced this pull request May 23, 2024
mungjin01 added a commit that referenced this pull request May 23, 2024
mungjin01 added a commit that referenced this pull request May 23, 2024
mungjin01 added a commit that referenced this pull request May 23, 2024
mungjin01 added a commit that referenced this pull request May 23, 2024
mungjin01 added a commit that referenced this pull request May 23, 2024
mungjin01 added a commit that referenced this pull request May 23, 2024
mungjin01 added a commit that referenced this pull request May 23, 2024
mungjin01 added a commit that referenced this pull request May 23, 2024
mungjin01 added a commit that referenced this pull request May 23, 2024
mungjin01 added a commit that referenced this pull request May 23, 2024
mungjin01 added a commit that referenced this pull request May 23, 2024
AAminha added a commit that referenced this pull request May 23, 2024
AAminha added a commit that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨Feature 기능 개발 이슈
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants