Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] 상세페이지 신청하기 섹션 구현 #52
[FEAT] 상세페이지 신청하기 섹션 구현 #52
Changes from 2 commits
e199d39
d913592
dde2d68
1e6fae2
94f656d
cb8bf2c
c554b48
b7ccc98
b701501
8f5b229
a67d2df
1d3148a
aa5fd39
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 API 연동할 때 post 성공하면 실행되는 걸로 하면 될 것 같아요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
더미 구성 괜찮은 것 같은데, 상세 소개 이미지랑, 이미지 키워드(방울방울)도 있다는 걸 생각하면 좋을 것 같아요. 그래서 더미를 여기에 두면 안되고, ExperienceDetailPage에서 여기로 props로 넘기는 방식을 선택하면 좋을 것 같습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 근데 profileSubtitle 저렇게 받기로 백엔드랑 협의 됐나요? 저번에 들었을 때는 다 쪼개서 받는다고 했었던 것 같아서요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
더미데이터 위치 옮겨야 된다고 생각만 하고 고치지는 않았었네요.. 근데 profileSubtitle 리스트로 넘겨주기로 했는지 한번에 넘겨주기로 했는지 정확히 기억이 안 나서 api 구현된 거 보고 고칠 예정이였습니다..!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오호 일단 알겠습니다