Added date_time column #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added date_time column as per TODO, refactored Unit_Converter.py
Fixing typos in README.md fixed the typo in the main function of weather_scraper.py
hamsolo474
commented
Mar 24, 2022
| else: | ||
| return fahrenheit | ||
|
|
||
|
|
There was a problem hiding this comment.
This was exactly the same as temperature(), so i DRYed it and followed the pattern we used for precipitation.
hamsolo474
commented
Mar 24, 2022
| row_dict['Date'] = date.strftime('%Y/%m/%d') | ||
| row_dict['Time'] = time.strftime('%I:%M %p') | ||
| row_dict['Date_time'] = ((time-blank)+date).strftime('%Y/%m/%d %I:%M:%S') |
There was a problem hiding this comment.
strftime will by default read a time and assume the date 1900/01/01, so i subtract that to get to 0000/00/00 and then all thats left is the timedelta of the time, which i then add to the date giving the full datetime
Karlheinzniebuhr
requested changes
Mar 24, 2022
There was a problem hiding this comment.
Thanks for the PR, can you delete the gitignore changes please? They are specific to your setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added date_time column as per TODO,
refactored Unit_Converter.py