-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added date_time column #8
Open
hamsolo474
wants to merge
3
commits into
Karlheinzniebuhr:master
Choose a base branch
from
hamsolo474:hams-fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
*.pyc | ||
*.csv | ||
.vscode/ | ||
.vscode/ | ||
.vs/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"SuppressEnvironmentCreationPrompt": true | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"ExpandedNodes": [ | ||
"", | ||
"\\util" | ||
], | ||
"SelectedNode": "\\weather_scraper.py", | ||
"PreviewInSolutionExplorer": false | ||
} |
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,16 +24,7 @@ def temperature(self, temp_string: str): | |
except Exception as e: | ||
print(f'{e}! probably caused by an empty row in the data') | ||
return 'NA' | ||
|
||
def dew_point(self, dew_point_string: str): | ||
try: | ||
fahrenheit = float(re.findall(self.extract_numbers_pattern, dew_point_string)[0]) if dew_point_string else 'NA' | ||
if self.system == "metric": | ||
celsius = (fahrenheit - 32) * 5/9 | ||
return round(celsius, self.round_to_decimals) | ||
else: | ||
return fahrenheit | ||
|
||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was exactly the same as temperature(), so i DRYed it and followed the pattern we used for precipitation. |
||
except Exception as e: | ||
print(f'{e}! probably caused by an empty row in the data') | ||
return 'NA' | ||
|
@@ -111,29 +102,31 @@ def clean_and_convert(self, dict_list: list): | |
for key, value in dict.items(): | ||
if key == 'Date': | ||
converted_dict['Date'] = value | ||
if key == 'Time': | ||
elif key == 'Time': | ||
converted_dict['Time'] = value | ||
if key == 'Temperature': | ||
elif key == 'Date_time': | ||
converted_dict['Date_time'] = value | ||
elif key == 'Temperature': | ||
converted_dict['Temperature'] = self.temperature(value) | ||
if key == 'Dew_Point': | ||
converted_dict['Dew_Point'] = self.dew_point(value) | ||
if key == 'Humidity': | ||
elif key == 'Dew_Point': | ||
converted_dict['Dew_Point'] = self.temperature(value) | ||
elif key == 'Humidity': | ||
converted_dict['Humidity'] = self.humidity(value) | ||
if key == 'Wind': | ||
elif key == 'Wind': | ||
converted_dict['Wind'] = value | ||
if key == 'Speed': | ||
elif key == 'Speed': | ||
converted_dict['Speed'] = self.speed(value) | ||
if key == 'Gust': | ||
elif key == 'Gust': | ||
converted_dict['Gust'] = self.speed(value) | ||
if key == 'Pressure': | ||
elif key == 'Pressure': | ||
converted_dict['Pressure'] = self.pressure(value) | ||
if key == 'Precip_Rate': | ||
elif key == 'Precip_Rate': | ||
converted_dict['Precip_Rate'] = self.precipitation(value) | ||
if key == 'Precip_Accum': | ||
elif key == 'Precip_Accum': | ||
converted_dict['Precip_Accum'] = self.precipitation(value) | ||
if key == 'UV': | ||
elif key == 'UV': | ||
converted_dict['UV'] = self.uv(value) | ||
if key == 'Solar': | ||
elif key == 'Solar': | ||
converted_dict['Solar'] = self.solar(value) | ||
|
||
converted_dict_list.append(converted_dict) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strftime will by default read a time and assume the date 1900/01/01, so i subtract that to get to 0000/00/00 and then all thats left is the timedelta of the time, which i then add to the date giving the full datetime