Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(LEMS-2617): Require $ to display TeX in axis labels #1865

Merged
merged 9 commits into from
Nov 15, 2024

Conversation

anakaren-rojas
Copy link
Contributor

@anakaren-rojas anakaren-rojas commented Nov 14, 2024

Summary:

  • Requires use of $ to render TeX by using the replaceOutsideTeX function.
  • Adds test to validate that both TeX and text are being rendered

Issue: LEMS-2617

Test plan:

  1. Navigate to Chromatic
  2. In the x Label or y Label inputs under Common Graph Settings , add a fraction 1/2 and then replace with $\frac{1}{2}$

Expected Results

a. 1/2 renders as text
b. $\frac{1}{2}$ renders as TeX
image

Screen recording

Comparison with current functionality and updated functionality using original reported bug text
https://github.com/user-attachments/assets/aeea74d3-70f4-417a-8a52-012a12a29e88

@anakaren-rojas anakaren-rojas self-assigned this Nov 14, 2024
@anakaren-rojas anakaren-rojas changed the title require $ to display tex fix(LEMS-2617): Require $ to display TeX in axis labels Nov 14, 2024
Copy link
Contributor

github-actions bot commented Nov 14, 2024

Size Change: -179 B (-0.01%)

Total Size: 1.29 MB

Filename Size Change
packages/perseus-editor/dist/es/index.js 699 kB -71 B (-0.01%)
packages/perseus/dist/es/index.js 420 kB -108 B (-0.03%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.9 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 77.8 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/strings.js 3.55 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link
Contributor

github-actions bot commented Nov 14, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (902a4a0) and published it to npm. You
can install it using the tag PR1865.

Example:

yarn add @khanacademy/perseus@PR1865

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1865

@anakaren-rojas anakaren-rojas marked this pull request as ready for review November 15, 2024 18:54
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/heavy-eels-agree.md, packages/perseus/src/widgets/interactive-graphs/mafs-graph.test.tsx, packages/perseus/src/widgets/interactive-graphs/backgrounds/axis-labels.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Member

@benchristel benchristel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left a suggestion for testing inline.

@anakaren-rojas anakaren-rojas merged commit ec5f877 into main Nov 15, 2024
8 of 9 checks passed
@anakaren-rojas anakaren-rojas deleted the LEMS-2617-revert-tex-in-axis-labels branch November 15, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants