-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(LEMS-2617): Require $
to display TeX in axis labels
#1865
Conversation
$
to display TeX in axis labels
Size Change: -179 B (-0.01%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (902a4a0) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1865 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1865 |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I left a suggestion for testing inline.
Summary:
$
to render TeX by using thereplaceOutsideTeX
function.Issue: LEMS-2617
Test plan:
Common Graph Settings
, add a fraction1/2
and then replace with$\frac{1}{2}$
Expected Results
a.
1/2
renders as textb.
$\frac{1}{2}$
renders as TeXScreen recording
Comparison with current functionality and updated functionality using original reported bug text
https://github.com/user-attachments/assets/aeea74d3-70f4-417a-8a52-012a12a29e88