Update browserslist #1939
Merged
Update browserslist #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (9095d18) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1939If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1939 |
|
Size Change: 0 B Total Size: 1.29 MB ℹ️ View Unchanged
|
jeremywiebe
added a commit
that referenced
this pull request
Dec 5, 2024
## Summary: This morning I landed a farily benign [PR](#1939) that is [generated periodically](https://github.com/Khan/perseus/actions/workflows/maintenance.yml) to update our browserslist reference. After landing it, it appears that running `yarn install` introduces changes to the `yarn.lock` file. This PR was created by running `yarn install` locally on a clean repo and committing the changes `yarn` made. The reason is not clear yet, but this PR applies the changes that `yarn` wants so that `main` can be clean again. Issue: "none" ## Test plan: `yarn install` Git repo is still clean Author: jeremywiebe Reviewers: mark-fitzgerald Required Reviewers: Approved By: mark-fitzgerald Checks: ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ gerald, ✅ gerald, ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1957
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
browserslistandcaniuse-litenpm packagesReviewing notes:
There should only be changes to the
yarn.lockfile inthis PR. Check that there is only 1
caniuse-litepackagereference in the
yarn.lockfile (the intent of thisupdate is to ensure that
caniuse-liteis on the latestversion and that there aren't multiple, conflicting
versions that different tools might see).
If everything looks fine, please approve this PR and then
land it (either with the Big Green Merge Button ™️ or by
using
git land <this pr #>in a terminal).