test(e2e): Fix all known screenshot test flakes #2878
Merged
+192
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hassoncs
changed the title
hassoncs
force-pushed
the
fix-screenshot-flakes-3
branch
5 times, most recently
from
9abdd7e to
19a782e
Compare
hassoncs
commented
Oct 9, 2025
|
|
||
| await page.waitForTimeout(1000) // Let the page settle to avoid flakes | ||
|
|
||
| await closeAllToastNotifications(page) |
There was a problem hiding this comment.
Notification closing is now built into takeScreenshot
hassoncs
force-pushed
the
fix-screenshot-flakes-3
branch
2 times, most recently
from
4877df9 to
454f524
Compare
- Add DOM stability helper to wait for page changes before screenshots - Replace notification helpers with DOM stability utilities - Enhance test setup with extension activation and model selector waits - Add GIF freezing and VSCode command execution for consistent screenshots - Update test files to reduce flakes and improve reliability - Add data-testid to model selector component for better test targeting Fixes screenshot flakiness in Playwright E2E tests by implementing stability checks and removing unreliable notification clearing.
hassoncs
force-pushed
the
fix-screenshot-flakes-3
branch
from
454f524 to
94b2d3a
Compare
hassoncs
force-pushed
the
fix-screenshot-flakes-3
branch
from
94b2d3a to
6ac2db0
Compare
chrarnoldus
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had screenshot tests using Chromatic for a while now, but we disabled them a couple weeks ago due to them being too flaky. This change should be 0 risk since these are just screenshots :)
With this pull request, I've addressed the three major sources of screenshot flakes:
Fixes: #2621